Optimize auto-advance logic in TimeRange
#70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the auto-advance logic in
<theoplayer-time-range>runs very frequently (every animation frame), even in cases where it's not really needed. This can cause performance issues on lower end devices and smart TVs.This PR improves this in a number of ways:
rAFcallback, avoid synchronous re-layouts as much as possible. We now cache the bar and thumb widths more aggressively.rAFcallback, check if the change incurrentTimeis large enough to be noticeable on the screen. That is: if the thumb would move by at least 1 pixel. If the change is less than that, we don't advance at all.currentTimeneeded to move the thumb by 1 pixel is larger than 250ms, then we don't run our auto-advance logic at all. In this case, it's sufficient to update on everytimeupdateevent, which is guaranteed to fire at least once every 250ms anyway. This improvement is especially noticeable for longer videos, where the thumb might not need to move for several seconds.