Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile fixes #2

Merged
merged 6 commits into from
May 6, 2014
Merged

Makefile fixes #2

merged 6 commits into from
May 6, 2014

Conversation

cornet
Copy link
Contributor

@cornet cornet commented Apr 30, 2014

Few fixes to Makefile:

  • Separate out install from build so un-privileged user can build
  • Install header files to /usr/local/include/RF24 for easy inclusion when using this library: i.e. #include <RF24.h>
  • Updated readme.md to reflect changes
  • Cleaned up readme.md while I was in there
    • Use consistent syntax for headers
    • Tabs -> Spaces
    • Indent code by 4 spaces rather than using backticks
    • Fix table so it renders correctly in github

@TMRh20
Copy link
Member

TMRh20 commented May 1, 2014

Thank you, could you add your readme.md updates to the copy in the RPi subfolder as well?

@cornet
Copy link
Contributor Author

cornet commented May 1, 2014

Yup can do, however would it make more sense to just have one of the readme files reference the other rather than having duplicate content ?

Another option could be to just symlink one to the other - I believe github honours this but could confuse anyone cloning the repo on Windows.

@TMRh20
Copy link
Member

TMRh20 commented May 1, 2014

Well, yes and no? A reference equals a link, which equals another mouse click and page load on the users part. I like having it in the main RPi folder, since it displays prominently when viewing on GitHub, while users are provided with a local copy when they download the repo.

On the ohter hand, It may be better to refer them to the online version, since it will be kept up-to-date, so an html link in the repo readme and/or a symlink may be the way to go?

I'm not of a strong opinion one way or the other, as long as things are clear and consistent to users.

TMRh20 added a commit that referenced this pull request May 6, 2014
@TMRh20 TMRh20 merged commit ee7f603 into nRF24:master May 6, 2014
TMRh20 added a commit to nRF24/RF24Network that referenced this pull request May 6, 2014
@TMRh20 TMRh20 added the bug label May 18, 2014
edoardoo pushed a commit to edoardoo/RF24 that referenced this pull request Dec 4, 2014
Copy header files to system during 'make install' for convenience,
edoardoo pushed a commit to edoardoo/RF24 that referenced this pull request Dec 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants