Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file parameter to output XML from input test url #35

Open
CelticMajora opened this issue Oct 14, 2021 · 1 comment
Open

Add file parameter to output XML from input test url #35

CelticMajora opened this issue Oct 14, 2021 · 1 comment
Labels
parked Awaiting feedback from reporter

Comments

@CelticMajora
Copy link

Currently, the json input to this tool includes a url with the filepath of a ran test, something like this:

{"test":{"id":3,"name":"package test","suiteID":0,"groupIDs":[2],"metadata":{"skip":false,"skipReason":null},"line":4,"column":3,"url":"file:///root/project/flutter/package/test/package_test.dart"},"type":"testStart","time":8218}

However the output XML will only include the classname currently. Something like this:

<testcase classname="flutter.package.test.package" name="package test" time="0.042">
  <failure message="1 failure, see stacktrace for details">Failure:\n\nExpected: false Actual: <true> </failure>
</testcase>

I'd expect the output XML to look something like this instead:

<testcase file="/root/project/flutter/package/test/package_test.dart" classname="flutter.package.test.package" name="package test" time="0.042">
  <failure message="1 failure, see stacktrace for details">Failure:\n\nExpected: false Actual: <true> </failure>
</testcase>

I'm happy to throw up a PR to work on this as well.

@rspilker
Copy link
Contributor

rspilker commented Jan 6, 2022

Can you point to a JUnit xml specification where the file attribute is defined?

@rspilker rspilker added the parked Awaiting feedback from reporter label Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parked Awaiting feedback from reporter
Projects
None yet
Development

No branches or pull requests

2 participants