Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Adjust UI according to feedback 1 #227

Open
2 of 3 tasks
milenark opened this issue Jan 18, 2024 · 0 comments
Open
2 of 3 tasks

[UI] Adjust UI according to feedback 1 #227

milenark opened this issue Jan 18, 2024 · 0 comments

Comments

@milenark
Copy link
Contributor

milenark commented Jan 18, 2024

TODO

React to Benedicts first feedback.

Feedback:

  • “Home”-Tab: You’ve done a great job! I really like the overall structure of this screen. It’s clear and you can quickly understand where to find what.
  • For the “Live Now” tiles, I would recommend that you think again about whether you really need the button for the room in the home view. On the one hand, you have a button on another button - which can lead to accidental entries - on the other hand, the idea behind your app is that you don’t have to search for the room but can watch the lecture from anywhere. Don’t get me wrong. The feature is still cool - but I think it would be better on the details page. I also think that the ID of the course (here e.g. IN0009) is a bit lost in the upper left corner. I have attached an alternative suggestion for you
  • “Settings”-View: Be sure to check your paddings again here. These are not yet completely uniform. Maybe you can make the whole thing look a bit more like iOS. But I know that sometimes it’s not that easy in Flutter. To ensure that your app corresponds to the Apple HIGs in this respect, I would also recommend that you adopt the system-wide theming in your app by default. So if iOS is in dark mode, your app will also be in dark mode. If you still want to set this independently, you could introduce a third state “System” in the Dark Mode settings. But then you would probably have to replace the toggle with another input option.
@milenark milenark self-assigned this Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant