Panic if chat conversation has "user" twice in a row #1128
oliverisaac
started this conversation in
Ideas
Replies: 3 comments
-
Alternatively, returning a 422 Unprocessable Entity would make it clear from the curl side of the equation that the input is invalid. |
Beta Was this translation helpful? Give feedback.
0 replies
-
Note the error behavior is inherit from the prompt template: https://github.com/TabbyML/registry-tabby/blob/main/models.json#L79 , which is also the standard behavior in HF transformers for similar prompt templates. Agree 422 is a better response code for this. |
Beta Was this translation helpful? Give feedback.
0 replies
-
Filing #1108 to track the issue |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Describe the bug
If you send a post body with "user" as the role back to back the processing panics and the server returns an empty reply.
Information about your version
Please provide output of
tabby --version
Information about your GPU
Apple Metal M3
Additional context
You can reproduce this using:
I realize this is "expected behavior" as the code is written, but it's unexpected as an end user. It would be nice if multiple "user" in a row would be concatenated.
Beta Was this translation helpful? Give feedback.
All reactions