Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Ui: duplicate subtag parents in tag editor #664

Open
3 tasks done
SkeleyM opened this issue Dec 23, 2024 · 1 comment · May be fixed by #665
Open
3 tasks done

[Bug]: Ui: duplicate subtag parents in tag editor #664

SkeleyM opened this issue Dec 23, 2024 · 1 comment · May be fixed by #665
Labels
Priority: High An important issue requiring attention TagStudio: Tags Relating to the TagStudio tag system Type: Bug Something isn't working as intended Type: UI/UX User interface and/or user experience
Milestone

Comments

@SkeleyM
Copy link
Contributor

SkeleyM commented Dec 23, 2024

Checklist

  • I am using an up-to-date version.
  • I have read the documentation.
  • I have searched existing issues.

TagStudio Version

Alpha v9.5.0 (main branch)

Operating System & Version

Windows 10 22H2

Description

In the tag editor, when creating or editing an existing tag's parent tags, pressing the '+' button multiple times on the same tag results in duplicate tags being added to the parent tags.

this is only a ui issue, saving the tag and reopening it in the editor shows only 1 tag
image

Expected Behavior

Only 1 unique tag should be in the parent tags

Steps to Reproduce

  1. create a new tag
  2. edit parent tags
  3. press the plus button multiple times on the same tag

Logs

2024-12-23 12:30:07 [info ] add_subtag_callback tag_id=1002
2024-12-23 12:30:08 [info ] add_subtag_callback tag_id=1002
2024-12-23 12:30:08 [info ] add_subtag_callback tag_id=1002

@SkeleyM SkeleyM added the Type: Bug Something isn't working as intended label Dec 23, 2024
@SkeleyM
Copy link
Contributor Author

SkeleyM commented Dec 23, 2024

i have already patched this in my local branch by replacing the list with a set, ill submit a pull request in a minute

@SkeleyM SkeleyM linked a pull request Dec 23, 2024 that will close this issue
@CyanVoxel CyanVoxel added Type: UI/UX User interface and/or user experience TagStudio: Tags Relating to the TagStudio tag system labels Dec 23, 2024
@CyanVoxel CyanVoxel moved this to 🚧 In progress in TagStudio Development Dec 23, 2024
@CyanVoxel CyanVoxel added this to the SQL Parity milestone Dec 23, 2024
@CyanVoxel CyanVoxel linked a pull request Dec 23, 2024 that will close this issue
@CyanVoxel CyanVoxel added the Priority: High An important issue requiring attention label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High An important issue requiring attention TagStudio: Tags Relating to the TagStudio tag system Type: Bug Something isn't working as intended Type: UI/UX User interface and/or user experience
Projects
Status: 🚧 In progress
Development

Successfully merging a pull request may close this issue.

2 participants