Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing duplicate chain icons in Portfolio #483

Closed
nickcamsmith opened this issue Feb 7, 2023 · 3 comments
Closed

Showing duplicate chain icons in Portfolio #483

nickcamsmith opened this issue Feb 7, 2023 · 3 comments
Assignees

Comments

@nickcamsmith
Copy link

Screen Shot 2023-02-08 at 9 51 12 am

Certain assets (ERC-20s) show the chain icon twice in Portfolio. This might be a known issue, but if so can we fix it because it looks like a bug

@tien
Copy link
Contributor

tien commented Feb 8, 2023

@alecdwm this is probably an issue with the balances lib? cc @JAhimaz

@alecdwm
Copy link
Member

alecdwm commented Feb 8, 2023

In the wallet we have the concept of mirrored tokens:

https://github.com/TalismanSociety/talisman/blob/8adc7f063b961cf0b2976f6ad947dcbea45ac6a8/apps/extension/src/ui/hooks/useDbCache.ts#L76-L91

We use this for acala, moonbeam, moonriver and moonbase because on those networks we can fetch the same native token balance from either the substrate or the evm side of the chain.

The plan is to integrate this from the wallet back into the balances library so that the webapp can also use it.

@alecdwm
Copy link
Member

alecdwm commented Jan 2, 2025

Fixed by c370f69 (included in #1237)

@alecdwm alecdwm closed this as completed Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants