Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: quick fixes #1733

Merged
merged 2 commits into from
Dec 10, 2024
Merged

fix: quick fixes #1733

merged 2 commits into from
Dec 10, 2024

Conversation

alecdwm
Copy link
Member

@alecdwm alecdwm commented Dec 9, 2024

  1. Adds a data-amount attribute for easier dev access to the exact token balance
Screenshot 2024-12-09 at 13 38 16
  1. Fixes the network infos rows to use the relay chain name (which we set) instead of the chainName (which is queried from the chain, and can be undesirable)
before after

@alecdwm alecdwm added the bug A bug label Dec 9, 2024
@alecdwm alecdwm requested review from chidg and 0xKheops December 9, 2024 03:51
@alecdwm alecdwm self-assigned this Dec 9, 2024
@alecdwm alecdwm enabled auto-merge (squash) December 9, 2024 03:54
0xKheops
0xKheops approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@0xKheops 0xKheops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alecdwm alecdwm merged commit 9880d9f into dev Dec 10, 2024
6 checks passed
@alecdwm alecdwm deleted the fix/quick-fixes branch December 10, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xKheops 0xKheops 0xKheops approved these changes

@chidg chidg Awaiting requested review from chidg

Assignees

@alecdwm alecdwm

Labels
bug A bug quick-fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alecdwm @0xKheops