Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin-query): add rule that disallows putting the result of query hooks directly in a React hook dependency array #7911

Merged
merged 5 commits into from
Aug 20, 2024

rename rule to "no-unstable-deps"

5191cec
Select commit
Loading
Failed to load commit list.
Merged

feat(eslint-plugin-query): add rule that disallows putting the result of query hooks directly in a React hook dependency array #7911

rename rule to "no-unstable-deps"
5191cec
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 20, 2024 in 0s

86.24% (+41.60%) compared to c7fb5fd

View this Pull Request on Codecov

86.24% (+41.60%) compared to c7fb5fd

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.24%. Comparing base (c7fb5fd) to head (5191cec).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #7911       +/-   ##
===========================================
+ Coverage   44.64%   86.24%   +41.60%     
===========================================
  Files         187       12      -175     
  Lines        7090      407     -6683     
  Branches     1575      158     -1417     
===========================================
- Hits         3165      351     -2814     
+ Misses       3562       42     -3520     
+ Partials      363       14      -349     
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query 86.24% <100.00%> (+2.24%) ⬆️
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query ∅ <ø> (∅)
@tanstack/react-query-devtools ∅ <ø> (∅)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client ∅ <ø> (∅)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)