Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(angular-query): support inject(QueryClient) #8292

Merged
merged 2 commits into from
Nov 14, 2024
Merged

fix(angular-query): support inject(QueryClient) #8292

merged 2 commits into from
Nov 14, 2024

Conversation

arnoud-dv
Copy link
Collaborator

@arnoud-dv arnoud-dv commented Nov 14, 2024 •
edited
Loading

It is initially surprising users of the library that inject(QueryClient) doesn't work and injectQueryClient() has to be used. This change allows inject(QueryClient) as expected.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Nov 14, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 62e59e7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 14, 2024

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8292

@tanstack/angular-query-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-experimental@8292

@tanstack/query-async-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-async-storage-persister@8292

@tanstack/query-broadcast-client-experimental

pnpm add https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8292

@tanstack/eslint-plugin-query

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-query@8292

@tanstack/query-core

pnpm add https://pkg.pr.new/@tanstack/query-core@8292

@tanstack/query-devtools

pnpm add https://pkg.pr.new/@tanstack/query-devtools@8292

@tanstack/query-persist-client-core

pnpm add https://pkg.pr.new/@tanstack/query-persist-client-core@8292

@tanstack/query-sync-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-sync-storage-persister@8292

@tanstack/react-query

pnpm add https://pkg.pr.new/@tanstack/react-query@8292

@tanstack/react-query-devtools

pnpm add https://pkg.pr.new/@tanstack/react-query-devtools@8292

@tanstack/react-query-next-experimental

pnpm add https://pkg.pr.new/@tanstack/react-query-next-experimental@8292

@tanstack/react-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/react-query-persist-client@8292

@tanstack/solid-query

pnpm add https://pkg.pr.new/@tanstack/solid-query@8292

@tanstack/solid-query-devtools

pnpm add https://pkg.pr.new/@tanstack/solid-query-devtools@8292

@tanstack/solid-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/solid-query-persist-client@8292

@tanstack/svelte-query

pnpm add https://pkg.pr.new/@tanstack/svelte-query@8292

@tanstack/svelte-query-devtools

pnpm add https://pkg.pr.new/@tanstack/svelte-query-devtools@8292

@tanstack/svelte-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/svelte-query-persist-client@8292

@tanstack/vue-query

pnpm add https://pkg.pr.new/@tanstack/vue-query@8292

@tanstack/vue-query-devtools

pnpm add https://pkg.pr.new/@tanstack/vue-query-devtools@8292

commit: 62e59e7

@codecov Codecov
Copy link

codecov bot commented Nov 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.25%. Comparing base (94891fd) to head (62e59e7).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8292       +/-   ##
===========================================
+ Coverage   46.00%   88.25%   +42.25%     
===========================================
  Files         200       17      -183     
  Lines        7526      264     -7262     
  Branches     1729       40     -1689     
===========================================
- Hits         3462      233     -3229     
+ Misses       3687       30     -3657     
+ Partials      377        1      -376
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 88.25% <66.66%> (-0.06%) ⬇️
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query ∅ <ø> (∅)
@tanstack/react-query-devtools ∅ <ø> (∅)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client ∅ <ø> (∅)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@arnoud-dv arnoud-dv marked this pull request as ready for review November 14, 2024 21:48
@arnoud-dv arnoud-dv merged commit 923736c into TanStack:main Nov 14, 2024
8 checks passed
@arnoud-dv arnoud-dv deleted the fix/inject-queryclient branch November 14, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation package: angular-query-devtools-experimental package: angular-query-experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@arnoud-dv