Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't navigate with Memory History Router #880

Closed
pakholeung37 opened this issue Dec 26, 2023 · 2 comments
Closed

Can't navigate with Memory History Router #880

pakholeung37 opened this issue Dec 26, 2023 · 2 comments

Comments

@pakholeung37
Copy link

Describe the bug

Cannot use 'Link', 'navigate.to', or any other navigation method with the createMemoryHistory API.
Btw, will tanstack router supports nested routers? It would be great if it has a example. remix-run/react-router#7375

Your Example Website or App

Steps to Reproduce the Bug or Issue

Simply adding a memoryHistory to the router history parameter will reproduce the issue.

Expected behavior

https://codesandbox.io/p/sandbox/wnq10opj68?file=%2Fsrc%2Findex.js react router support.

Screenshots or Videos

No response

Platform

  • OS: [e.g. macOS, Windows, Linux]
  • Browser: [e.g. Chrome, Safari, Firefox]
  • Version: [e.g. 91.1]

Additional context

No response

@mer10z
Copy link

mer10z commented Dec 27, 2023

@pakholeung37
Copy link
Author

@tannerlinsley I tried 1.0.5,memory history will trigger onUpdate when trigger pushState api. But go, replace, back, forward api will not. memory history doesn't have popStateEvent or pushStateEvent.

2023-12-29.10.26.18.mov

reproduce https://github.com/pakholeung37/tanstack-router-bug-report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants