Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(start-vite-plugin): copy the TanStack Start specific plugin logic into its own standalone vite plugin #1768

Merged
merged 15 commits into from
Jun 18, 2024

Conversation

SeanCassiere
Copy link
Member

@SeanCassiere SeanCassiere commented Jun 17, 2024

A new @tanstack/start-vite-plugin that only has the vite plugin logic related to TanStack Start. Currently, this means, only the prepending of the "use server" directive to createServerFn calls.

I've added a couple more tests and logic to handle cases where:

  • A destructured createServerFn import is renamed like import { createServerFn as serverFn } ....
  • A star import is used like import * as TanStackStart ...; TanStackStart.createServerFn.

This PR doesn't remove any existing functionality from the @tanstack/router-vite-plugin package. In a separate PR I'll remove the Start logic from the @tanstack/router-vite-plugin package will be removed and patch the @tanstack/start package.

Copy link

nx-cloud bot commented Jun 17, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d84c856. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@SeanCassiere SeanCassiere marked this pull request as ready for review June 18, 2024 02:01
@SeanCassiere SeanCassiere changed the title feat(start-vite-plugin): move the TanStack Start specific plugin logic into its own standalone vite plugin feat(start-vite-plugin): copy the TanStack Start specific plugin logic into its own standalone vite plugin Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant