Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reach browser max height pixels #616

Open
2 tasks done
hyanmandian opened this issue Oct 24, 2023 · 0 comments
Open
2 tasks done

Reach browser max height pixels #616

hyanmandian opened this issue Oct 24, 2023 · 0 comments

Comments

@hyanmandian
Copy link

hyanmandian commented Oct 24, 2023

Describe the bug

I'm doing some POC to check if I'll be able to render a larger list and I face some issues with the current approach you use by setting the height of the parent element to create the scrollable area. If the list size is long it could beat the max height value which is:

Firefox: 33554400px
Chrome:  33554428px

https://stackoverflow.com/questions/16637530/whats-the-maximum-pixel-value-of-css-width-and-height-properties

In that way is impossible to keep scrolling until the end of the list

Your minimal, reproducible example

https://codesandbox.io/p/sandbox/romantic-breeze-tjpnxm?embed=1&file=%2Fsrc%2Fmain.tsx%3A4%2C21

Steps to reproduce

  • Create a list with 1677723 items and each item should have 20px
  • Cannot scroll to see the last item

Expected behavior

  • Create a list with 1677723 items and each item should have 20px
  • Be able to see the last item

How often does this bug happen?

None

Screenshots or Videos

No response

Platform

macOS - Chrome

tanstack-virtual version

3.0.0-alpha.1

TypeScript version

No response

Additional context

No response

Terms & Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.
@hyanmandian hyanmandian changed the title Reach chrome max height pixels Reach browser max height pixels Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant