Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore the 'Auto Play' status from before joining the sync session when leaving it #6

Open
Tandashi opened this issue Jul 30, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@Tandashi
Copy link
Owner

It would be nice if the 'Auto Play' status was restored back to normal when leaving a sync session so you don't need to manually turn it back on everytime you watched something with someone else.

@Tandashi Tandashi added the enhancement New feature or request label Jul 30, 2020
@Tandashi
Copy link
Owner Author

Might not be so easy since you can not always restore the stored setting since someone might change it manually.

Stored value: Autoplay on

Person start up new tab with youtube and no sync session -> we restore autoplay to on
Person disables autoplay in that tab
Person reloads tab -> we restore autoplay to on since it is what we have stored

Now we would have turned autoplay back on although the person has disabled it manually.

To fix this we might need to listen to every toggle of the autoplay button and store the value in the localstorage even outside sync sessions to be able to restore the correct state everytime. Just something we need to keep in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant