Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more country specific transliterations #107

Open
Tazinho opened this issue Jan 4, 2018 · 1 comment
Open

Support more country specific transliterations #107

Tazinho opened this issue Jan 4, 2018 · 1 comment

Comments

@Tazinho
Copy link
Owner

Tazinho commented Jan 4, 2018

For example german:
Ä -> AE; Ö-> OE, Ü -> UE,
ä -> ae, ö -> oe, ü -> ue, ß -> ss

@Tazinho
Copy link
Owner Author

Tazinho commented May 10, 2018

Danish doesn't seem to work, see:

> to_any_case(c("Æ", "Ae"), transliterations = "Latin-ASCII")
[1] "ae" "ae"
> to_any_case(c("æ", "ae"), transliterations = "Latin-ASCII")
[1] "ae" "ae"
> to_any_case(c("Ø", "Oe"), transliterations = "Latin-ASCII")
[1] "o"  "oe"
> to_any_case(c("ø", "oe"), transliterations = "Latin-ASCII")
[1] "o"  "oe"
> to_any_case(c("Å", "Aa"), transliterations = "Latin-ASCII")
[1] "a"  "aa"
> to_any_case(c("å", "aa"), transliterations = "Latin-ASCII")
[1] "a"  "aa"

All together:

  • German + tests
  • Danish + tests
  • Swedish + tests
  • Norwegian + tests
  • Finnish + tests
  • Icelandic + tests
  • Faroese + tests
  • Greenlandic + tests
  • Czech + tests
  • Dutch + tests
  • Turkish + tests

Also Need to update the following files

  • function documentations

  • Readme

  • News

  • Also need to allow users to specify a list of replacements. Done via named transliteration arguments.

  • need to document the mappings here in a more transparent and structured way.

See discussions:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant