Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modfier is not applicable in Button Component. #3

Closed
8954sood opened this issue Aug 23, 2024 · 0 comments · Fixed by #5
Closed

Modfier is not applicable in Button Component. #3

8954sood opened this issue Aug 23, 2024 · 0 comments · Fixed by #5
Assignees
Labels
bug Something isn't working

Comments

@8954sood
Copy link
Member

If the status of the button is disabled, it seems that the modifier is newly created.
In my opinion, it is recommended that the takeIf of the code below returns a new object and this occurs.

Surface(
        modifier = modifier
            .clickable(
                onClick = onClick,
                enabled = enabled,
                interactionSource = interactionSource,
                indication = rememberBounceIndication(buttonConfig.shape),
            )
            .takeIf { enabled } ?: Modifier.alpha(0.5f),
        shape = buttonConfig.shape,
        color = buttonColors.containerColor,
        contentColor = buttonColors.contentColor,
    ) {
@8954sood 8954sood added the bug Something isn't working label Aug 23, 2024
@8954sood 8954sood self-assigned this Aug 23, 2024
@8954sood 8954sood mentioned this issue Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant