Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more explaination needed #1

Open
touseefbsb opened this issue Jun 23, 2019 · 2 comments
Open

more explaination needed #1

touseefbsb opened this issue Jun 23, 2019 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@touseefbsb
Copy link

Hey there, I like all of your projects and all work you do in uwp community, just wanted to suggest that maybe its better to put some more examples in readme and explain a little how this library can be productive for uwp devs, also how will this work with winui library since that is currently the standard fluent design controls library which automatically adapts to windows version.
Having said that I wanna say this does looks promising, and I appreciate the work you do in uwp :)

@ikarago ikarago self-assigned this Jun 24, 2019
@ikarago ikarago added the documentation Improvements or additions to documentation label Jun 24, 2019
@ikarago
Copy link
Collaborator

ikarago commented Jun 24, 2019

Thanks for the comment! I've updated the Readme a bit, I hope the usage and the purpose of the package is a little bit more clear now. :) If so, feel free to close the Issue, and if not, please let me know what you're still missing. ;)

@touseefbsb
Copy link
Author

yeah so readme is improved and it helps thanks however I have some questions.

  1. so these set of styles you have I assume you copied them from generic.xaml from a specific sdk version? and then made them fluent and that is wht we will be using? Assuming that is the case, the worry I have with it is it will be static styles and for example new templates for controls come in new sdk version or winui itself we wont be able to take advantage of those styles automatically assuming our app is running on multiple windows 10 versions. So what plan do you have to encounter that situation? I think that can be solved by including this project to winui itself? so that all controls are updated regularly and work across different versions?

Apart from that worry I really like this project and the idea seeing we can do fluent style on controls like textblock, texbox etc bcz these controls were lacking it in winui library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants