Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPE 1.5.0 update #373

Merged
merged 21 commits into from
Aug 23, 2024
Merged

RPE 1.5.0 update #373

merged 21 commits into from
Aug 23, 2024

Conversation

ChickenPige0n
Copy link
Contributor

No description provided.

@sjfhsjfh sjfhsjfh changed the title Rpe 150 update RPE 1.5.0 update Aug 15, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个地方要不改一下吧, 我感觉单独弄个enum会好些,不要用string

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改成 enum 然后 impl 一个 .play 会不会好些?不用到处写 if

@sjfhsjfh
Copy link
Contributor

sjfhsjfh commented Aug 16, 2024

拉个表

  • 冗余字段支持 fix
  • 自定义 HitSound
  • gif 图

@sjfhsjfh
Copy link
Contributor

@Mivik 有空review&squash merge一下吧,最后这个workaround实在有点没头绪

@sjfhsjfh sjfhsjfh merged commit 1dc2a5d into TeamFlos:main Aug 23, 2024
YuevUwU added a commit to YuevUwU/phira that referenced this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants