Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes when open Bandcamp #11074

Closed
6 tasks done
cw2k opened this issue May 14, 2024 · 3 comments · Fixed by TeamNewPipe/NewPipeExtractor#1177
Closed
6 tasks done

Crashes when open Bandcamp #11074

cw2k opened this issue May 14, 2024 · 3 comments · Fixed by TeamNewPipe/NewPipeExtractor#1177
Assignees
Labels
bandcamp Service, https://bandcamp.com/ bug Issue is related to a bug

Comments

@cw2k
Copy link

cw2k commented May 14, 2024

Checklist

  • I am able to reproduce the bug with the latest version given here: CLICK THIS LINK.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

0.27.0

Steps to reproduce the bug

  1. Switch to Bandcamp mode
  2. Paste and load http://projectconvolution.bandcamp.com

Expected behavior

Parse website and load songs.

Actual behavior

Crash on load.
Seems like it can't parse the website data correctly.

Screenshots/Screen recordings

No response

Logs

Exception

  • User Action: requested channel
  • Request: http://projectconvolution.bandcamp.com
  • Content Country:
  • Content Language: en-
  • App Language: en
  • Service: Bandcamp
  • Version: 0.27.0
  • OS: Linux Android 10 - 29
Crash log

org.schabi.newpipe.extractor.exceptions.ParsingException: Download failed
	at org.schabi.newpipe.extractor.services.bandcamp.linkHandler.BandcampChannelLinkHandlerFactory.getId(BandcampChannelLinkHandlerFactory.java:45)
	at org.schabi.newpipe.extractor.linkhandler.LinkHandlerFactory.fromUrl(LinkHandlerFactory.java:83)
	at org.schabi.newpipe.extractor.linkhandler.ListLinkHandlerFactory.fromUrl(ListLinkHandlerFactory.java:41)
	at org.schabi.newpipe.extractor.linkhandler.ListLinkHandlerFactory.fromUrl(ListLinkHandlerFactory.java:35)
	at org.schabi.newpipe.extractor.StreamingService.getChannelExtractor(StreamingService.java:280)
	at org.schabi.newpipe.extractor.channel.ChannelInfo.getInfo(ChannelInfo.java:51)
	at org.schabi.newpipe.util.ExtractorHelper.lambda$getChannelInfo$4(ExtractorHelper.java:126)
	at org.schabi.newpipe.util.ExtractorHelper.$r8$lambda$BOLWstv98dC8pFAG_uir5gPXYwY(ExtractorHelper.java:0)
	at org.schabi.newpipe.util.ExtractorHelper$$ExternalSyntheticLambda13.call(R8$$SyntheticClass:0)
	at io.reactivex.rxjava3.internal.operators.single.SingleFromCallable.subscribeActual(SingleFromCallable.java:43)
	at io.reactivex.rxjava3.core.Single.subscribe(Single.java:4855)
	at io.reactivex.rxjava3.internal.operators.single.SingleDoOnSuccess.subscribeActual(SingleDoOnSuccess.java:35)
	at io.reactivex.rxjava3.core.Single.subscribe(Single.java:4855)
	at io.reactivex.rxjava3.internal.operators.single.SingleSubscribeOn$SubscribeOnObserver.run(SingleSubscribeOn.java:89)
	at io.reactivex.rxjava3.core.Scheduler$DisposeTask.run(Scheduler.java:644)
	at io.reactivex.rxjava3.internal.schedulers.ScheduledRunnable.run(ScheduledRunnable.java:65)
	at io.reactivex.rxjava3.internal.schedulers.ScheduledRunnable.call(ScheduledRunnable.java:56)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:301)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
	at java.lang.Thread.run(Thread.java:919)
Caused by: java.net.UnknownServiceException: CLEARTEXT communication to projectconvolution.bandcamp.com not permitted by network security policy
	at okhttp3.internal.connection.RealConnection.connect(RealConnection.kt:188)
	at okhttp3.internal.connection.ExchangeFinder.findConnection(ExchangeFinder.kt:226)
	at okhttp3.internal.connection.ExchangeFinder.findHealthyConnection(ExchangeFinder.kt:106)
	at okhttp3.internal.connection.ExchangeFinder.find(ExchangeFinder.kt:74)
	at okhttp3.internal.connection.RealCall.initExchange$okhttp(RealCall.kt:255)
	at okhttp3.internal.connection.ConnectInterceptor.intercept(ConnectInterceptor.kt:32)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
	at okhttp3.internal.cache.CacheInterceptor.intercept(CacheInterceptor.kt:95)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
	at okhttp3.internal.http.BridgeInterceptor.intercept(BridgeInterceptor.kt:83)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
	at okhttp3.internal.http.RetryAndFollowUpInterceptor.intercept(RetryAndFollowUpInterceptor.kt:76)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
	at okhttp3.internal.connection.RealCall.getResponseWithInterceptorChain$okhttp(RealCall.kt:201)
	at okhttp3.internal.connection.RealCall.execute(RealCall.kt:154)
	at org.schabi.newpipe.DownloaderImpl.execute(DownloaderImpl.java:163)
	at org.schabi.newpipe.extractor.downloader.Downloader.get(Downloader.java:77)
	at org.schabi.newpipe.extractor.downloader.Downloader.get(Downloader.java:32)
	at org.schabi.newpipe.extractor.services.bandcamp.linkHandler.BandcampChannelLinkHandlerFactory.getId(BandcampChannelLinkHandlerFactory.java:36)
	... 21 more
	Suppressed: java.net.UnknownServiceException: CLEARTEXT communication to projectconvolution.bandcamp.com not permitted by network security policy
		... 40 more
	Suppressed: java.net.UnknownServiceException: CLEARTEXT communication to projectconvolution.bandcamp.com not permitted by network security policy
		... 40 more
	Suppressed: java.net.UnknownServiceException: CLEARTEXT communication to projectconvolution.bandcamp.com not permitted by network security policy
		... 40 more


Affected Android/Custom ROM version

No response

Affected device model

No response

Additional information

No response

@cw2k cw2k added bug Issue is related to a bug needs triage Issue is not yet ready for PR authors to take up labels May 14, 2024
@fynngodau fynngodau self-assigned this May 14, 2024
@opusforlife2 opusforlife2 added bandcamp Service, https://bandcamp.com/ and removed needs triage Issue is not yet ready for PR authors to take up labels May 15, 2024
@opusforlife2
Copy link
Collaborator

Changing that http to https is a workaround.

Interestingly, once it loads, swiping from the About tab to Tracks causes a crash.

@cw2k
Copy link
Author

cw2k commented May 15, 2024

Nice.
Sometimes things can be simple.

Anyway I wonder about ya exception handling strategy. Seem there are no try...catch handling at all.
So each tiny little error crashes the whole app.

Why not put up some crash handlers at critical functions/ modules like ExtractorHelper or Download that catches and reports errors there.
Image a playlist with pleny titles and just one 'critical' link. Skip this because an error occurred is no big deal.
However stopping the music and the need to restart the app is really annoying especially when driving car and you need to stop to fiddle around on the smartphone.

@fynngodau
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bandcamp Service, https://bandcamp.com/ bug Issue is related to a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants