Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when adding video to the queue after next video starts playing #11091

Closed
6 tasks done
dk949 opened this issue May 23, 2024 · 9 comments · Fixed by #11614
Closed
6 tasks done

Crash when adding video to the queue after next video starts playing #11091

dk949 opened this issue May 23, 2024 · 9 comments · Fixed by #11614
Assignees
Labels
bug Issue is related to a bug

Comments

@dk949
Copy link

dk949 commented May 23, 2024

Checklist

  • I am able to reproduce the bug with the latest version given here: CLICK THIS LINK.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

0.27.0

Steps to reproduce the bug

  1. Start playing a video
  2. Enqueue another video
  3. Long press on another video in the related items tab1 to show the modal
  4. Wait for the currently playing video to go to the next one in the queue whilst the modal is on screen
  5. Press the enqueu button on the modal

Expected behavior

The video the modal was spawned from is enqueued or some message about why this can't be done.

Actual behavior

Crash (log attached)

Screenshots/Screen recordings

No response

Logs

Exception

  • User Action: ui error
  • Request: ACRA report
  • Content Country: GB
  • Content Language: en-GB
  • App Language: en_GB
  • Service: none
  • Version: 0.27.0
  • OS: Linux Android 14 - 34
Crash log

java.lang.IllegalStateException: Fragment RelatedItemsFragment{82c241b} (edb74a84-566c-4db7-a17d-cde599994f16) not attached to a context.
	at androidx.fragment.app.Fragment.requireContext(Fragment.java:972)
	at org.schabi.newpipe.info_list.dialog.StreamDialogDefaultEntry.lambda$static$3(StreamDialogDefaultEntry.java:53)
	at org.schabi.newpipe.info_list.dialog.StreamDialogDefaultEntry.$r8$lambda$vJPfXGxkVEGzC3RaucaklOZ4WRo(StreamDialogDefaultEntry.java:0)
	at org.schabi.newpipe.info_list.dialog.StreamDialogDefaultEntry$$ExternalSyntheticLambda5.onClick(R8$$SyntheticClass:0)
	at org.schabi.newpipe.info_list.dialog.InfoItemDialog.lambda$new$2(InfoItemDialog.java:76)
	at org.schabi.newpipe.info_list.dialog.InfoItemDialog.$r8$lambda$rolB38hFbFwRPfIy0nmFKZx8iWo(InfoItemDialog.java:0)
	at org.schabi.newpipe.info_list.dialog.InfoItemDialog$$ExternalSyntheticLambda2.onClick(R8$$SyntheticClass:0)
	at androidx.appcompat.app.AlertController$AlertParams$3.onItemClick(AlertController.java:1068)
	at android.widget.AdapterView.performItemClick(AdapterView.java:376)
	at android.widget.AbsListView.performItemClick(AbsListView.java:1362)
	at android.widget.AbsListView$PerformClick.run(AbsListView.java:3658)
	at android.widget.AbsListView$3.run(AbsListView.java:4844)
	at android.os.Handler.handleCallback(Handler.java:958)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loopOnce(Looper.java:230)
	at android.os.Looper.loop(Looper.java:319)
	at android.app.ActivityThread.main(ActivityThread.java:8919)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:578)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1103)


Affected Android/Custom ROM version

Android 14

Affected device model

Samsung galaxy s23+

Additional information

No response

Footnotes

  1. The tab between comments and video description.

@dk949 dk949 added bug Issue is related to a bug needs triage Issue is not yet ready for PR authors to take up labels May 23, 2024
@opusforlife2
Copy link
Collaborator

Are you selecting the next videos from the Related videos tab?

@opusforlife2 opusforlife2 added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label May 31, 2024
@dk949
Copy link
Author

dk949 commented May 31, 2024

From the related items tab, yes.

(the middle one where left is comments and right is description)

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label May 31, 2024
@opusforlife2
Copy link
Collaborator

Try selecting the next videos from search results. If I'm understanding it correctly, the bug shouldn't occur that way. If it does it might be a different problem.

@opusforlife2 opusforlife2 added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label May 31, 2024
@dk949
Copy link
Author

dk949 commented May 31, 2024

When selecting a video from search results or the "what's new" tab - no crash.

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label May 31, 2024
@opusforlife2
Copy link
Collaborator

Thanks for confirming! Could you edit the description to specifically state that this happens with Related videos?

@opusforlife2 opusforlife2 added waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. and removed needs triage Issue is not yet ready for PR authors to take up labels May 31, 2024
@dk949
Copy link
Author

dk949 commented May 31, 2024

Done

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label May 31, 2024
@rmtilde
Copy link
Contributor

rmtilde commented Oct 8, 2024

Hi, can I work on this issue?

@opusforlife2
Copy link
Collaborator

Hey @rmtilde! Thanks for showing an interest in contributing.

@ShareASmile
Copy link
Collaborator

ShareASmile commented Oct 16, 2024

Stacktrace is (nearly) identical in #8640 so very likely cause of bug is the same.

I successfully reproduced #5470 giving same stacktrace as given by OP here.

So mentioning those issues here & marking them duplicates of this one (as this one has latest stacktrace).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants