Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background Player buffers frequently #4687

Closed
g1t3m opened this issue Oct 28, 2020 · 27 comments · Fixed by #4562
Closed

Background Player buffers frequently #4687

g1t3m opened this issue Oct 28, 2020 · 27 comments · Fixed by #4562
Labels
bug Issue is related to a bug player Issues related to any player (main, popup and background)

Comments

@g1t3m
Copy link

g1t3m commented Oct 28, 2020

Newpipe Version: 20.2
Device: Pixel 4 XL
OS: Calyx OS on Android 10
System Webview: Android System Webview
Network: Wi-Fi

Description: When playing audio in the background, either of a single video or playlist, the audio track will buffer frequently at random intervals. Audio sometimes does not continue playing until I return NewPipe app to foreground. This has been an issue since app version 20.1. This also may be an issue with my OS or device, as I've also had this issue with YouTube Vanced.

I really appreciate everything you all do to bring us this fantastic app, and I especially appreciate the quick turnaround from version 20.1 to 20.2. I cannot use anything else because NewPipe is that awesome! Thank you all for making an outstanding app.

@opusforlife2
Copy link
Collaborator

Please use a template in the future. https://github.com/TeamNewPipe/NewPipe/issues/new/choose

Can you try this with another service, like Soundcloud or Peertube?

@g1t3m
Copy link
Author

g1t3m commented Oct 28, 2020 via email

@opusforlife2
Copy link
Collaborator

This is only with the background player? Not popup or main player?

@opusforlife2
Copy link
Collaborator

Could you also see if your issue is the same as #4209?

@g1t3m
Copy link
Author

g1t3m commented Oct 28, 2020 via email

@opusforlife2
Copy link
Collaborator

Alright, thanks for testing!

By the way, your email client is adding pointless extra text to your comments.

@opusforlife2 opusforlife2 added bug Issue is related to a bug player Issues related to any player (main, popup and background) labels Oct 28, 2020
@aladar42
Copy link
Contributor

Im not sure if this belongs here or as a separaye issue, but I am also getting frequent buffers, except for me the buffering gets stuck and does not resume playback until i close the player and restart the video. It happens mostly during minor network hiccups, but also when the system performs some heavier operation, like opening a browser with a lot of tabs.

@g1t3m
Copy link
Author

g1t3m commented Oct 28, 2020

Edit:I just tried this with my Bluetooth earbuds on the Galaxy Express phone, and I have not had any issues with the Background Player. So this may be an issue with my Pixel phone and/or its OS/Webview. This might also not be specific to my phone if @aladar42 's comment is anything to go by.

Okay, I just tested this on my Samsung Galaxy Express phone running Android 7.1 with the same Newpipe version and system webview, and this issue does not occur on that device compared to my Pixel 4 XL. I did this with wired earbuds, so I'll try again with Bluetooth and see if the results are similar.

@opusforlife2
Copy link
Collaborator

@g1t3m Newpipe has nothing to do with Webview.

@Moon-Palace-16
Copy link

I've been experiencing the same problem with the background player, and, like @aladar42, I have to close the player and restart the video. I have a Samsung Galaxy S5, running Android 5.1.1 (Lollipop). I was also having some trouble with this in 0.20.1, too.

@fihe
Copy link

fihe commented Oct 31, 2020

I have also been having this problem with the background player. It only happens when I have a queue, never when I am playing only one song. The rotating circle or hourglass will come up but the song will never resume. The only way to fix it is to clear the queue and play only one song at a time.
Screenshot_20201030-210813
Screenshot_20201030-210803

@Stypox
Copy link
Member

Stypox commented Oct 31, 2020

Could you all test if this is fixed by #4562?

@fihe
Copy link

fihe commented Nov 1, 2020

I downloaded the new version of the app and I'm still getting the same problem. When I download the app-debug.zip and use the version of the app installed from that, I just can't open any videos at all.

@PrSunflower
Copy link

PrSunflower commented Nov 9, 2020

Hi, I am having exactly the same problem, very good description by @g1t3m . For me it started in version 0.20.0 and issue is still present in 0.20.2.

Device info

  • Android 10
  • Nokia 7.2 ("stock" Android like Google Pixel)

Screenshots

Screenshot_20201109-132128

Screenshot_20201109-132133


Additional info

  • Only occurs with background player, "live" player unaffected.
  • Can happen with every content, YouTube videos and YouTube Music songs.
  • When playback stops it never resumes, it is stuck buffering.
  • Two solutions: skip to the next item in the playlist OR switch to Main > press Play > then press Background
  • I couldn't find any pattern for the issue to happen, it seems strangely random:
    • Some days ago I was adding multiple songs to the queue one by one while the first item was still playing, playback stopped at ~3/4 of the song. I skipped and for each item in the playlist the playback stopped during the last half.
    • This morning I launched a playlist in the background, playback stopped at ~2/3 of the first item but after that every item played correctly without stopping.

@opusforlife2
Copy link
Collaborator

For me it also started in version 0.20.1

@PrSunflower Sure it's not there in 0.20.0?

@PrSunflower
Copy link

@opusforlife2 I can't remember exactly...

I think the bug happened in the version where the UI changed. Was it 0.20.0?

@Stypox
Copy link
Member

Stypox commented Nov 9, 2020

When playback stops it never resumes, it is stuck buffering.

@PrSunflower This part is fixed by #4562, included in 0.20.3

@opusforlife2
Copy link
Collaborator

Was it 0.20.0?

@PrSunflower Yes.

@fihe
Copy link

fihe commented Nov 10, 2020 via email

@PrSunflower
Copy link

@opusforlife2 Ok, my bad. I edited my previous comment and wrote 0.20.0.

@Stypox Oh yeah that's cool! Do you know approx. when will v0.20.3 stable be available?

@opusforlife2
Copy link
Collaborator

@PrSunflower The release candidate is already out for you to test! See the pinned issue.

@PrSunflower
Copy link

@opusforlife2 Alright that's cool thanks! I am receiving NewPipe updates via the F-Droid upstream repository and I don't want to break it so I'll just wait 😉

@opusforlife2
Copy link
Collaborator

@PrSunflower All the test APKs you'll encounter in this repo will install separately from the main app. This was done deliberately to ensure that testers don't have to take pains to backup and restore stuff all the time.

@opusforlife2
Copy link
Collaborator

Guys, could you all test the APK in #4562 once again? We need confirmation on whether or not this issue is fixed.

Closing until someone replies.

@PrSunflower
Copy link

@opusforlife2 I have been using the APK for some days now, the background buffering works really well.

In my opinion this issue seems to be fixed.

@opusforlife2
Copy link
Collaborator

Thanks for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug player Issues related to any player (main, popup and background)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants
@aladar42 @Stypox @opusforlife2 @g1t3m @PrSunflower @Moon-Palace-16 @fihe and others