Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong entry for Gigaget in Licenses dialog #4890

Closed
4 tasks done
ypnos opened this issue Nov 15, 2020 · 2 comments · Fixed by #4892
Closed
4 tasks done

Wrong entry for Gigaget in Licenses dialog #4890

ypnos opened this issue Nov 15, 2020 · 2 comments · Fixed by #4892
Labels
bug Issue is related to a bug

Comments

@ypnos
Copy link

ypnos commented Nov 15, 2020

Checklist

Steps to reproduce the bug

  • Go to "About NewPipe"
  • Switch to "Licenses" tab

Actual behaviour

"Giga Get" is listed with GPLv2 license.

Expected behavior

"Giga Get" is not listed at all as it was removed from the sources, or it is listed with GPLv3 license.
The source of GigaGet, https://github.com/PaperAirplane-Dev-Team/GigaGet states that the license is actually GPLv3.
Note that GPLv2 would be incompatible with GPLv3 and the inclusion of GPLv2 sources into NewPipe a license violation.

@ypnos ypnos added the bug Issue is related to a bug label Nov 15, 2020
@TheAssassin
Copy link
Member

Note that GPLv2 would be incompatible with GPLv3 and the inclusion of GPLv2 sources into NewPipe a license violation.

Just to avoid confusion in the future: this remark is irrelevant to this specific dependency, as it is licensed under the GPLv3, just like NewPipe.

The source of GigaGet, https://github.com/PaperAirplane-Dev-Team/GigaGet states that the license is actually GPLv3.

Indeed. Listing it as GPLv2 is wrong (I don't think it's a big deal, but it needs to be fixed).

"Giga Get" is not listed at all as it was removed from the sources, or it is listed with GPLv3 license.

Are you sure it's not used any more? In that case, let's just get rid of it.

@Stypox
Copy link
Member

Stypox commented Nov 15, 2020

No, gigaget is still used, though completely changed in many parts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants