Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate videos in background player causes it to behave improperly #6122

Closed
4 tasks done
luckcolors opened this issue Apr 20, 2021 · 2 comments
Closed
4 tasks done
Labels
bug Issue is related to a bug

Comments

@luckcolors
Copy link

luckcolors commented Apr 20, 2021

Checklist

Steps to reproduce the bug

  1. Equeue to the bakground player 1 video, let's call it video X
  2. Equeue to the bakground player 1 video, let's call it video Y
  3. Enque to the background player video X again.
    Now our playlist looks like this:
    • X
    • Y
    • X
      Note this specific playlist pattern is not the cause as this problem happens when any kind of duplicate is present in any order, for example to test this it's even enough to just have one video present more than one time for example.
    • X
    • X
  4. Start playing from the beginning is fine but the problem happens on starting to play the first duplicated video

Actual behaviour

If the user selects to start playing on the first appearance of a any video, everything works fine the playlist plays until reaching a duplicate video on wich it starts loading forever and gets stuck on.
If the user manually selects to play from a duplicated video the player is unable to do so and "jumps" to the first appearance in the playlist of said video.

Expected behavior

One would either expect to not be able to add duplicate videos in any playlist or for them to act as an individual entry in the playlist.
This is especially a problem when enqueuing multiple playlists or simply re-enquequing an already present video as it can cause duplicates to appear wich then proceed to cause this issue.

If i were to be personally in favour of one of those 2 options i would assume allowing for duplicates is the most natural option.

@luckcolors luckcolors added the bug Issue is related to a bug label Apr 20, 2021
@ShinyLuxray
Copy link

I'll add that this issue is present in version 0.21.2, and affects videos in foreground mode as well.

Anecdotally, this bug must have been introduced at some point as I first encountered it today when I played a saved playlist containing duplicate videos which worked before. That is to say, I do appreciate contributors' efforts as the queuing interface has improved substantially these last few months.

@Stypox
Copy link
Member

Stypox commented Jul 31, 2021

This was a duplicate and is fixed by #6712

@Stypox Stypox closed this as completed Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug
Projects
None yet
Development

No branches or pull requests

3 participants