Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider to release v0.10.0 #682

Closed
theScrabi opened this issue Sep 8, 2017 · 20 comments
Closed

Consider to release v0.10.0 #682

theScrabi opened this issue Sep 8, 2017 · 20 comments
Labels
discussion This needs to be discussed before anything is done

Comments

@theScrabi
Copy link
Member

theScrabi commented Sep 8, 2017

Can we now consider to release version v0.10.0?
Now where more or less all feature work stable enough to be usable.

@theScrabi theScrabi added the discussion This needs to be discussed before anything is done label Sep 8, 2017
@ghost
Copy link

ghost commented Sep 8, 2017 via email

@theScrabi
Copy link
Member Author

theScrabi commented Sep 8, 2017

I'm not a huge fan, of putting to much changes into one version. Because the more U change the more unstable it gets. Also I made the experience that user will find bugs you aren't aware of.

I'd like to release now, and than stick to a constant release cycle again. (Before the huge refactoring of the extractor we had an almost every week cycle).

We can consider multi service support in a few versions later, but not now.

@ghost
Copy link

ghost commented Sep 8, 2017 via email

@theScrabi
Copy link
Member Author

@mauriciocolli updated the extractor here

@mauriciocolli
Copy link
Contributor

mauriciocolli commented Sep 8, 2017

I already updated the extractor 23f70d6.

But one thing to always keep in mind when updating is the database. If we update carelessly we could end up clearing the database, which is not very cool.

PS: It still have some annoying bugs in the extractor, so I wouldn't recommend release right now (YouTube has been changing in the past days).

@ghost
Copy link

ghost commented Sep 8, 2017 via email

@theScrabi
Copy link
Member Author

This is why we should consider to have a beta app. Because there will always be bugs. Some people can get along with a few bugs some can't. If we have beta people could decide them selfs.

@ghost
Copy link

ghost commented Sep 8, 2017 via email

@theScrabi
Copy link
Member Author

theScrabi commented Sep 8, 2017

I'd do it the way we do it now, just put a beta in front of the version. like
v0.10.0
v-beta-0.10.1 or beta-v0.10.1

(We'd have to put it in front because only this way fdroid can distinguish between beta and nonbeta)

@theScrabi
Copy link
Member Author

theScrabi commented Sep 10, 2017

YouTube has been changing in the past days

I saw that. Due to that new UI some of the things that still work are rather unclear if they will work in the future.
Example: In the channels view on youtube there was a "load next" button. We used that button to get the url for the ajax request for the next video items. This button does not exist in the new UI anymore. It seems NP is till capable to load the old website where this button still exists. But for how long?

But atm I'm more concerned of the database, because it would not be such a huge problem if the crawler stopped working while a new version is released. We then just hat to asap release a version that fixes that problem (happens to the past will happen to the future as well).

@mauriciocolli: What in particular does not yet work? I couldn't find anything that drove me that crazy that I would not release yet.

@mauriciocolli
Copy link
Contributor

I fixed some error that caused these annoyances (at least the ones that I noticed), but just a brief summary:

  • Uploader name when getting next streams
  • Trying to extract YouTube mix from search was resulting in error

They are very annoying because every time they ask the user to report (in almost every search, in every "next videos"...).

@theScrabi
Copy link
Member Author

Yea. I see.

@theScrabi
Copy link
Member Author

theScrabi commented Sep 13, 2017

Although these are extractor related bugs right? I have to admid that It's not that bad. Over all NewPipe is pretty usable. So form my perception of user experience of usage I'd vote for release.

Anyway is the database still an issue tho?

@mauriciocolli
Copy link
Contributor

Well, it was bad before I fixed them (asking the user to report to do the most trivial of things like search).

The database was more of a warning about the fact that we'd have to create multiple tiny migrations, which is not ideal. But that will not be a problem anymore as we'll have a different build so we can see when it's the best moment to release.

@theScrabi
Copy link
Member Author

Well if its not the code, then there is nothing that can prevent us from release.

@theScrabi
Copy link
Member Author

So I've released:
https://github.com/TeamNewPipe/NewPipe/releases/tag/v0.10.0

Shame on me if something went wrong.

@TobiGr
Copy link
Member

TobiGr commented Sep 18, 2017

Open youtube links directly from search (fixes #35) #692
Support dark theme in file picker #699 (fixes #646)

Correct me if I am wrong but I think these two were only merged to dev branch and are not included in the 0.10.0 release.

@theScrabi
Copy link
Member Author

you are right :) removed it

@rbozan
Copy link

rbozan commented Sep 21, 2017

The version of NewPipe on fdroid hasn't updated I think

@theScrabi
Copy link
Member Author

Several apps on fdroid haven't updated yet. I don't know what takes them so long again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion This needs to be discussed before anything is done
Projects
None yet
Development

No branches or pull requests

4 participants