Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notch not filled in full screen mode #7915

Closed
5 tasks done
Envel-Nikita-Gutsenkov opened this issue Feb 20, 2022 · 3 comments · Fixed by #7924
Closed
5 tasks done

Notch not filled in full screen mode #7915

Envel-Nikita-Gutsenkov opened this issue Feb 20, 2022 · 3 comments · Fixed by #7924
Labels
bug Issue is related to a bug

Comments

@Envel-Nikita-Gutsenkov
Copy link

Checklist

  • I am able to reproduce the bug with the latest version.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

0.22.0

Steps to reproduce the bug

  1. open video
  2. the video is not full screen even in fill mode

Expected behavior

before the last update, there was a similar problem with the menu, but now the videos are not displayed in full screen. my screen has a small cutout for the camera, but this does not prevent me from using the interface or watching videos until the latest version is released

Actual behavior

the video is not full screen even in fill mode

Screenshots/Screen recordings

Screenshot_2022-02-20-23-14-46-208_org schabi newpipe
Screenshot_2022-02-20-23-14-37-055_org schabi newpipe

Logs

Affected Android/Custom ROM version

Android 11 miui 12

Affected device model

Xiaomi 11 lite 5g ne

Additional information

No response

@Envel-Nikita-Gutsenkov Envel-Nikita-Gutsenkov added the bug Issue is related to a bug label Feb 20, 2022
@SameenAhnaf
Copy link
Collaborator

SameenAhnaf commented Feb 21, 2022

This is intentional. See: #7451

You may optionally show notch all the time. Go toSettings>Display> Show Notch in invidual apps>Select Always show notch for Newpipe app

@litetex litetex changed the title UI bug Notch not filled in full screen mode Feb 21, 2022
@litetex litetex added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Feb 21, 2022
@litetex litetex removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Feb 21, 2022
@litetex
Copy link
Member

litetex commented Feb 21, 2022

From #7913:

this pr #7451 alters the way fullscreen landscape view is shown for displays with punchhole camera. before the video truly played fullscreen also overlaying the camera area. it used far more screen in total then now with v22 where the whole camera bar is blacked out/not used. viewing area is decreased and unsymmetrical. i understand the idea behind it but it is a regression for devices without a notch.

issues is seen here and here

the red line marks the area which was used by versions before v22. it was tested with two different devices running latest stock software: huawei nova 5t and oneplus 8t.

@AnkS4
Copy link

AnkS4 commented Nov 2, 2023

This is intentional. See: #7451

You may optionally show notch all the time. Go toSettings>Display> Show Notch in invidual apps>Select Always show notch for Newpipe app

For MIUI 14, it's Settings>Notifications & Control Centre>Status Bar>Notch in invidual apps>Select Always show notch for Newpipe app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants