Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification fixes #4410

Merged
merged 2 commits into from
Oct 5, 2020
Merged

Notification fixes #4410

merged 2 commits into from
Oct 5, 2020

Conversation

Stypox
Copy link
Member

@Stypox Stypox commented Oct 5, 2020 •
edited
Loading

What is it?

  • Bug fix (user facing)
  • Feature (user facing)
  • Code base improvement (dev facing)
  • Meta improvement to the project (dev facing)

Fixes the following issue(s)

  • Fixes Fast forward crush  #4390 by just adding a null check.
  • Prevents Android from showing how much time ago a notification was created or updated: seeing when a notification was last updated is mostly useless, since it is distracting and does not really provide a useful information due to it being changed every time the notification is updated; also other players hide it. The freed space could be used to show other useful information in the future (or now, if you have any suggestion)

Testing apk

@baraa272 @opusforlife2
app-debug.zip

Agreement

@Stypox
Fix crash on fast forward
06fb89f
@Stypox
Hide player notification "when" time
a88f511 
It is useless to see how much time ago a player notification was created
@TobiGr TobiGr added the bug Issue is related to a bug label Oct 5, 2020
TobiGr
TobiGr approved these changes Oct 5, 2020
View reviewed changes
Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Did not test it

@opusforlife2
Copy link
Collaborator

Tested both. Fixed!

@TobiGr TobiGr merged commit 9f63e2d into TeamNewPipe:dev Oct 5, 2020
This was referenced Nov 10, 2020
Closed
Merged
@Stypox Stypox deleted the notification-fixes branch August 4, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiGr TobiGr TobiGr approved these changes

Assignees
No one assigned
Labels
bug Issue is related to a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fast forward crush
3 participants
@Stypox @opusforlife2 @TobiGr