Replace specific enqueue options with one #4425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The enqueue options won't be shown in the dialogs if the Player service is not running. When it's running one item (enqueue stream) will be shown and enqueues the item into the Player type which is currently selected.
opusforlife2
reviewed
Oct 6, 2020
Stypox
requested changes
Oct 6, 2020
app/src/main/java/org/schabi/newpipe/player/helper/PlayerHolder.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/util/StreamDialogEntry.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/util/StreamDialogEntry.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/util/StreamDialogEntry.java
Outdated
Show resolved
Hide resolved
|
I've pushed your suggestions/requested changes and updated the OP. |
Stypox
previously approved these changes
Oct 6, 2020
|
And also works after some testing |
|
@vkay94 thank you! |
3 tasks
This was referenced Oct 30, 2020
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
This PR replaces the enqueue options within the StreamDialogEntry-dialogs with one.
Dev:
PlayerHolderto determine the current runningPlayerType(VIDEO, AUDIO, POPUP).enqueuewhich automatically checks which type is running and enqueues the stream accordingly to the right player.showStreamDialog(see more in User)StreamDialogEntryitems and their strings.User:
If there is no player playing a stream, then the options for queuing won't be shown - there is no need for them, in this case it's the same as start playing in background/popup.
But If there is a stream playing then there'll be the entry
Enqueuewhich enqueues the next stream without interrupting the current flow.I hope the behavior is what you've expected @TobiGr
Fixes the following issue(s)
Testing apk
app-debug-2.zip
Agreement