Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask for confirmation before clearing even single video queues #4463

Merged
merged 1 commit into from
Oct 10, 2020
Merged

Ask for confirmation before clearing even single video queues #4463

merged 1 commit into from
Oct 10, 2020

Conversation

opusforlife2
Copy link
Collaborator

@opusforlife2 opusforlife2 commented Oct 9, 2020

What is it?

  • Bug fix (user facing)
  • Feature (user facing)
  • Code base improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Removed the condition that there must be more than one video in the queue for the confirmation dialogue to be shown.

Fixes the following issue(s)

Testing apk

app-debug.zip

Agreement

Even when there is only one video in it.
@opusforlife2 opusforlife2 marked this pull request as draft October 9, 2020 15:05
@nbmrjuhneibkr
Copy link

I'll also copy this suggestion here, just in case someone thinks that there is a reason to have a choice between current (v0.20) behavior of the option and the one introduced by this PR.

Instead of being limited to yes or no, "Ask for confirmation before clearing a queue" could have 3 options: always, never and "when the queue contains multiple tracks".

@opusforlife2 opusforlife2 marked this pull request as ready for review October 9, 2020 16:53
@opusforlife2
Copy link
Collaborator Author

@wb9688 Happy now? >:(

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested, and it works. Thank you @opusforlife2 @avently ;-)

@Stypox Stypox merged commit cf75e40 into TeamNewPipe:dev Oct 10, 2020
@opusforlife2
Copy link
Collaborator Author

Thank you @avently!

@opusforlife2 opusforlife2 deleted the confirm_queue_delete_one_track branch October 10, 2020 20:03
@avently
Copy link
Contributor

avently commented Oct 10, 2020

@opusforlife2 without you it wouldn't be possible.

@opusforlife2 opusforlife2 changed the title Ask for confirmation before clearing queue even if only 1 video in it Ask for confirmation before clearing even single video queues Nov 8, 2020
This was referenced Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Ask for confirmation before clearing a queue" doesn't work if queue contains only one track
4 participants