Format all XML resources

[wb9688]

What is it?

• Bug fix (user facing)
• Feature (user facing)
• Code base improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

Format all XML resources using Ctrl+Alt+L in Android Studio. I've also manually added newlines at the end of XML resources that currently didn't have a newline.

Fixes the following issue(s)

Seeing stuff like https://github.com/TeamNewPipe/NewPipe/pull/4453/files#diff-8093b831702ba14428d2d99c9edded66 in PRs, which makes it harder to review.

Agreement

• I carefully read the contribution guidelines and agree to them.

[avently]

Finally. THANK YOU.

[connectety]

Nice work.
IMO this PR should add xml-linting to make sure the work will not be undone in like a year.
I mean this can always be checked in the review, but that will often mean an extra commit and might be just forgotten.

[wb9688]

@connectety: That was also what I was thinking, however I'm not aware of a way to run Android Studio's XML formatter from the command line.

[Stypox]

Can we just assume Ctrl+Alt+L does his job correctly and merge directly? ;-)
345 files are too many to check ;-)

Anyway, I took a brief look and there does not seem to be any strange things. I'm not sure if we would need to do some deeper analysis or we can just trust AS. Maybe we can so something like this?

[wb9688]

@Stypox: It's just some XML, I'd trust Android Studio for that. Also from taking a quick look at what it did (for the first about 100 files).

[wb9688]

Fwiw the source code of Android Studio's XML formatter is at https://android.googlesource.com/platform/tools/base/+/refs/tags/studio-4.0.0/sdk-common/src/main/java/com/android/ide/common/xml/

[Stypox]

Ok, then @TobiGr merge

[TacoTheDank]

You have no idea how happy this makes me.

[opusforlife2]

@TacoTheDank You do seem like the kind of person who likes a well-kept codebase. 🤭

[Stypox]

For some reason the Synk vulnerability checks are failing, but I don't have the rights to access the results and find out why

[TobiGr]

snyk is also failing for other PRs. There are no dependency changes in this PR, so this should be good to merge.