Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Core KTX functions. #4547

Merged
merged 3 commits into from
Oct 18, 2020
Merged

Use Core KTX functions. #4547

merged 3 commits into from
Oct 18, 2020

Conversation

Isira-Seneviratne
Copy link
Member

@Isira-Seneviratne Isira-Seneviratne commented Oct 17, 2020 •
edited
Loading

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Use some functions in the Core KTX library.

APK testing

debug.zip

Due diligence

@Isira-Seneviratne Isira-Seneviratne changed the title Use core KTX functions. Use Core KTX functions. Oct 17, 2020
@Stypox
Copy link
Member

Stypox commented Oct 18, 2020

When building the apk, could you build the debug one, so that it does not have the same package name as NewPipe? The gradle build process takes care of chaning the app package name only for debug builds

Stypox
Stypox approved these changes Oct 18, 2020
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for improving the codebase! I tested and everything works fine, as before!

@Stypox Stypox merged commit a73baf3 into TeamNewPipe:dev Oct 18, 2020
@Isira-Seneviratne
Copy link
Member Author

When building the apk, could you build the debug one, so that it does not have the same package name as NewPipe? The gradle build process takes care of chaning the app package name only for debug builds

I will, thanks for letting me know.

@Isira-Seneviratne Isira-Seneviratne deleted the Use_Core_KTX_functions branch October 18, 2020 08:32
This was referenced Nov 10, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stypox Stypox Stypox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Isira-Seneviratne @Stypox