Fix IllegalStateException after onSaveInstanceState #4549
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
This PR fixes a random crash happening sometimes when messing with the miniplayer while it's still starting. According to this SO the solution is just to replace
commit()
withcommitAllowingStateLoss()
, which may not be a real solution (state loss should never happen in theory) but is surely better than making the app crash completely.This was the stack trace:
APK testing
app-debug.zip
Due diligence