Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't rearrange lists by dragging the thumbnails #4550

Merged
merged 1 commit into from
Oct 18, 2020

Conversation

Stypox
Copy link
Member

@Stypox Stypox commented Oct 17, 2020

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

This PR removes touch listeners from thumbnails in playlists and queues, making the latter reorderable only using the handle on the right. Though I think the drag-by-thumbnail was introduced for some reason, so I'd be ok if this PR gets rejected because of a real-life use of the drag-by-thumbnail.

Fixes the following issue(s)

Closes #4523

APK testing

@nbmrjuhneibkr @opusforlife2 @Swyter what do you think of this?
app-debug.zip

Due diligence

@opusforlife2
Copy link
Collaborator

Tested. Works fine!

@opusforlife2 opusforlife2 added bug Issue is related to a bug GUI Issue is related to the graphical user interface labels Oct 17, 2020
@TobiGr TobiGr added the player Issues related to any player (main, popup and background) label Oct 17, 2020
@TobiGr TobiGr merged commit 333cf0a into TeamNewPipe:dev Oct 18, 2020
This was referenced Nov 10, 2020
@tfga
Copy link

tfga commented Jan 24, 2021

I miss this so much. I was totally used to dragging by the thumbnails. It makes for a much better UX, IMO. In the beginning, it's a little annoying, you drag by accident a lot, but then you get used to it. I was completely addicted. Now I have to go to the right end of the item, it's more difficult to see which item you're actually moving... I hate it.

Can you bring this back? Please? 🙏🏻

I'll start making my own builds, just so I can revert this PR.

@Stypox
Copy link
Member Author

Stypox commented Jan 24, 2021

@tfga unfortunately this won't be brought back, as many users, expecially new ones, only found annoying the fact that items could be dragged by the thumbnail. I am sorry to know that this situation does not suit you.

@tfga
Copy link

tfga commented Jan 25, 2021

@Stypox
😢
Ok. Thanks for the reply.

@Orion983
Copy link

Orion983 commented Jan 25, 2021

Maybe it could be optional? Just an idea

@Stypox
Copy link
Member Author

Stypox commented Jan 25, 2021

@HTSamurai no, we can't introduce a new setting for every niche element, the settings screen would blow up

@Stypox Stypox deleted the no-drag-thumbnails branch August 4, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't rearrange lists by dragging the thumbnails
5 participants