-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change YouTube subscription import instructions to Google takeout #4759
Conversation
Instructions should also be changed on the website: https://newpipe.schabi.org/FAQ/tutorials/import-export-data/ https://github.com/TeamNewPipe/website/blob/master/_tutorials/import-export-data.html |
Tested the .apk, import worked with no isssue. |
Tested .APK file, no issues was found |
Works for me too. |
I updated the url to https://takeout.google.com/takeout/custom/youtube , see the extractor PR for discussion |
@Stypox The import works with the debug app. Thanks for doing this. |
Works, the only issue is that google sends you an archive and you will have to extract the json by hand. You should therefore maybe also note that on the instructions or let newpipe extract it if necessary |
@atar-axis as I said I don't think we can have NewPipe extract the json automatically, sincs different localizations have different names and structures |
I think all we need to do is extracting the |
@TobiGr this should also be merged, it is only a string change |
The instructions don't tell the user to extract the file and find the subscriptions.json on beforehand of importing. At least those instructions should be added before merging |
@atar-axis no, it does: |
So then it is an translation issue, it doesn't on the german version. Thanks for clarification! |
@Stypox what do you think about that? I could give it a try, shouldn't be too hard |
@atar-axis Oh, yeah, translations will be there only after syncing WebLate ;-)
I am not sure if that would work out perfectly (maybe there are still issues in some localizations? idk). Anyway, after a second thought I think we should detect automatically if the user is passing us a json file directly (in which case we parse it as we do currently) or a zip archive (in which case we try to look for the json). This should bring us the best of both worlds, since we would both be able to pass a single file and the whole archive. Feel free to open a PR in the NewPipe repo (imo it's better not to put this part in the Extractor since it has to do with files, zips, etc.). Thank you :-D |
The APK worked like a charm! Thanks for doing this! |
What is it?
Description of the changes in your PR
This are the new steps:
Point 7, i.e. extracting things from the archive, can't be done automatically, due to the different structure for different localizations.
Fixes the following issue(s)
Fixes #4720
Relies on the following changes
TeamNewPipe/NewPipeExtractor#452
APK testing
@simula67 @inigosola @Djay86 @IvanProgramming @saecki
app-debug.zip
Due diligence