Fix playlist select dialog and do some refactoring #4771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Yes, thank you, I was on a business trip and could successful ly test it today, no more errors also the videos are playing again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
This PR fixes a bug where some UI code was not being run on the main thread due to a missing
.observeOn(AndroidSchedulers.mainThread()). I also did some refactoring of code insideSelectPlaylistFragment.java, since there were some unused things and some things were messy.Fixes the following issue(s)
Fixes #4769
APK testing
@RaveZero could you test if this fixes your issue?
app-debug.zip
Due diligence