-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add korean translation of README.md #4845
Conversation
Is this the standard way to provide a translated README for GitHub repositories? Will Korean users automatically see it when opening the repo? |
@Stypox See for example https://github.com/tiimgreen/github-cheat-sheet/blob/master/README.md which contains links to translated versions of itself. However, it uses README.ko.md instead of README_KO.md like Min-Tae has done here. |
@KIMMINTAE98 thank you! Can you rename the file to |
@Stypox Note that I haven't found any official Github documentation on this. What I've said above is just from researching what seem to be the best practices in other repos. |
@Stypox no, in README.md there shoul be a line like "korean translation", otherwise nobody will know about this translation. Also, why are section titles not translated? |
@B0pol The Readme I linked has:
We could add that to our Readme. |
All READMEs should contains links to translated versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
What is it?
Description of the changes in your PR
to active the participation of the Korean contributors or download of Korean users.
Due diligence