Also just use colorControlActivated in the base V19 theme, instead of using the prefix android: in each V21 service theme

System is now not restarted with `System.exit(0)`.
Instead it is done properly by finishing the activity and restarting the activity. This allows preference changes which are queued up asynchronously through `apply` to be applied.

https://sonarcloud.io/organizations/teamnewpipe/rules?open=java%3AS2885&rule_key=java%3AS2885

https://sonarcloud.io/organizations/teamnewpipe/rules?open=java%3AS112&rule_key=java%3AS112

Instead pass the value through the methods as parameter

This patch changes click handlers for feed (Whats new) so that they do
nothing while the feed is refreshing and the items being clicked are not
visible.

…ually

instead use service.stopService() which inturn calls stopSelf() and
triggers hopefully onDestroy() to be called. Eventually we have to make
sure that all ServiceConnections are closed to successfully stop the service
now!

Cleanup within stopService() and not only onDestroy()

So we make sure that all listeners can react to onServiceStopped()
and close their ServiceConnections. Afterwards the android framework
is ready to stop the Service.

- code is easier to read
- duplication of code reduced

…iceConnection leak

- bugfix: have ServiceConnection created only once!

- select the context within the PlayerHolder to start, stop, bind or unbind the service
  -> we have to make sure the Service is started AND stopped within the same context
  -> so let PlayerHolder be the one to select the context

- remove removeListener() and replace the call with setListener(null)
- Compatibility: use ContextCompat.startForegroundService instead of startService()

…g video during rotation (#6502)

Playing a video in VideoDetailFragment and rotating the screen to landscape (back and forth more often)
can trigger this error message. Especially if rotation for whatever reason takes long or
playing a high resolution (1080p) video.

The underlying logcat error messages:
05-12 16:38:38.251 24920 26037 E Surface : getSlotFromBufferLocked: unknown buffer: 0x923fc810
05-12 16:38:38.251 24920 26037 W ACodec  : [OMX.qcom.video.decoder.avc] can not return buffer 35 to native window

The problem is that that Exoplayer is trying to write to our -- during rotation -- no longer existant
(VideoDetailFragment) SurfaceView.

Solution:
Implementing SurfaceHolder.Callback and using DummySurface we can now handle the lifecycle of the Surface.

How?: In case we are no longer able to write to the Surface eg. through rotation/putting in
background we can set a DummySurface. Although it only works on API >= 23.
Result: we get a little video interruption (audio is still fine) but we won't get the
'Unrecoverable player error occurred' error message.

This implementation is based on and more background information:
 'ExoPlayer stuck in buffering after re-adding the surface view a few time 2703'

 -> exoplayer fix suggestion link
  google/ExoPlayer#2703 (comment)

This is a workaround for the emulator bug ReactiveCircus/android-emulator-runner#160

Bump gradle

Update some libraries

Specify emulator-build version in CI job

Made the thumbnail in the minimized player visible again

Improved metadata layout, better tags accessibility

Convert PlayerHolder to Singleton; cleanup in VideoDetailFragment; Player/MainPlayer do not call onDestroy() directly

Remove option to immediately commit pref changes on import

Prevent error msg: 'Unrecoverable player error occurred' while playin…

Core team does not want to convert to Kotlin yet and sees Java as the easier to learn and more well adopted language.

This stance might of course change in the future. For example it could be reasonable to do a complete transition to Kotlin once it is decides that the minSdk is raised to 21 or higher, as we then could use Jetpack particularly Lifecycle and Compose.

Remove api level 29 from android ci tests

We don't need to call ``updateRelativeTimeViews`` when the activity is paused, because the user likely won't  notice it.
Despite that onResume already calls ``updateRelativeTimeViews`` so there is no need to do that twice.

…agment

…mpat

Use GestureDetectorCompat.

Ref: #6483 (comment)

Added comments disabled functionallity

Add instrumented tests for LocalPlaylistManager.createPlaylist

Moved seekbar preview up a bit, so the finger is not obstructing the view

More onActivityResult deprecation fixes

Apply theme to switches

Bump compileSdkVersion to 30.

Player seekbar thumbnail preview

Fix some build warnings

Added a Kotlin section in CONTRIBUTING.md

….3.0

Update AppCompat to 1.3.0.

Use Kotlin methods in LicenseFragment.

so that it doesn't annoy people that are building this repo ;)

Use the correct extractor dependency

…t_getInsets

Use WindowInsetsCompat's getInsets() method.

Fix format of some kotlin files

Dismiss download dialog correctly

Fix grid span count calculation

The action got fixed and released https://github.com/ReactiveCircus/android-emulator-runner/releases/tag/v2.19.1

Readd api level 29 to android CI tests

From #4562: Disable player stream preloading only if the current stream is going to be replaced for sure (see this). equals() was implemented for PlayQueueItems, so that (only) the url is compared when checking them.

After the cookies are extracted from the recaptcha webview make it load an empty
page to prevent youtube being loaded unecessarily in the background.

Co-authored-by: Stypox <stypox@pm.me>

Fix duplicate items in queue causing endless buffering

Delete pending missions with invalid storage

…e creator of a video.

…s, and apply some code style suggestions.

The toolbarSearchTheme was accidently broken with #6456, see #6456 (comment) for details.
This commit restores the old behavior

…-activity

Prevent recaptcha webview from keeping youtube loaded in background