-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update a bunch of libraries #7499
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build is failing.
Did you check for API changes?
This comment has been minimized.
This comment has been minimized.
2e8d575
to
de5a99a
Compare
Kotlin 1.6 was changing how AndroidX Room was working, see here: https://developer.android.com/jetpack/androidx/releases/room#2.4.0-rc01. We should wait for AndroidX Room 2.4.0 before upgrading to Kotlin 1.6. |
de5a99a
to
5ae5e7b
Compare
Added runners library non-transitively to resolve |
Seems I somehow missed this: yes :) everything looks good, I didn't see anything in the changelogs that was noteworthy or that required code changes. |
@TacoTheDank |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a quick test, LGTM.
If my comment above is clarified the PR get's my approval
5ae5e7b
to
8f0a344
Compare
So I analyzed "before" and "after" APKs... Results: Google Material resources be getting thicc 😔 Also, I bumped AGP to 7.0.4 because it just got released. |
8f0a344
to
a924f81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is it?
Description of the changes in your PR
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence