Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Already playing in background toast #7568

Merged
merged 3 commits into from
Dec 31, 2021
Merged

Add Already playing in background toast #7568

merged 3 commits into from
Dec 31, 2021

Conversation

vhouriet
Copy link
Contributor

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Added "Already playing in background" toast when clicking "Backgound" instead of not showing anything at all.

Before/After Screenshots/Screen Record

  • Before:
before.mp4
  • After:
after.mp4

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@triallax triallax added the feature request Issue is related to a feature in the app label Dec 22, 2021
@vhouriet vhouriet force-pushed the vhouriet_feature_already-playing-in-backgroud branch from e2917ad to 989bcbf Compare December 23, 2021 21:13
litetex
litetex previously approved these changes Dec 26, 2021
View reviewed changes
litetex
litetex previously approved these changes Dec 26, 2021
View reviewed changes
@sonarcloud
Copy link

sonarcloud bot commented Dec 26, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

litetex
litetex approved these changes Dec 26, 2021
View reviewed changes
Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Minified code a bit (This time without failing to copy-paste stuff)

@litetex litetex merged commit ee19ea6 into TeamNewPipe:dev Dec 31, 2021
@vhouriet vhouriet deleted the vhouriet_feature_already-playing-in-backgroud branch December 31, 2021 16:37
litetex added a commit to litetex/NewPipe that referenced this pull request Jan 3, 2022
@litetex
Revert "Merge pull request TeamNewPipe#7568 from vhouriet/vhouriet_fe…
2ff9d22 
…ature_already-playing-in-backgroud"

This reverts commit ee19ea6, reversing
changes made to 6b490ee.
@litetex litetex mentioned this pull request Jan 3, 2022
Merged
5 tasks
litetex added a commit to litetex/NewPipe that referenced this pull request Jan 23, 2022
@litetex
Revert "Merge pull request TeamNewPipe#7568 from vhouriet/vhouriet_fe…
49b1649 
…ature_already-playing-in-backgroud"

This reverts commit ee19ea6, reversing
changes made to 6b490ee.
Stypox added a commit that referenced this pull request Jan 23, 2022
@Stypox
Merge pull request #7614 from litetex/revert-7568
1531a51 
Revert #7568
This was referenced Feb 11, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@litetex litetex litetex approved these changes

Assignees
No one assigned
Labels
feature request Issue is related to a feature in the app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vhouriet @litetex @triallax