Fixes view of sub-channel icon when not in use

[Jaspann]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

Removes a blank sub-channel icon if you watch a Peertube video and then a non-PeerTube video after.

• Does not remove the icon if you watch a PeerTube video with a channel that does not have a sub-channel icon, to avoid confusion

Before/After Screenshots/Screen Record

• Before:
  https://peertube.co.uk/videos/watch/8afb877a-9f14-4178-b9fb-a0e0c6bfa215
  At the end in the bottom right corner of the YouTube creator icon, the app still tries to show you the sub-channel icon like it would in PeerTube. This is because whey you load up a video it only checks whether it needs to create the icon for a video and never if it needs to be hidden.

• After:
  https://peertube.co.uk/videos/watch/e778dfb5-0bbf-4997-a02d-c8ccb241230b
  At the end in the bottom right corner of the YouTube creator icon, the app no longer tries to show you the sub-channel icon.

Fixes the following issue(s)

• Fixes Peertube channel sub-icon persists in non-Peertube videos #7557

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

• I read the contribution guidelines.

[litetex]

Thank you for the PR.
However this doesn't fix the problem completely:

NewPipe/app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java

Lines 1524 to 1531 in 2158802

	if (!isEmpty(info.getSubChannelName())) {
	displayBothUploaderAndSubChannel(info);
	} else if (!isEmpty(info.getUploaderName())) {
	displayUploaderAsSubChannel(info);
	} else {
	binding.detailUploaderTextView.setVisibility(View.GONE);
	binding.detailUploaderThumbnailView.setVisibility(View.GONE);
	}

if we encounter the else-Block the view will still be visible.

I would suggest simply putting binding.detailSubChannelThumbnailView.setVisibility(View.GONE); before the above code block (line 1523 or so) to fix the problem.

[Jaspann]

@litetex Yeah, I was unsure what to think of that else statement, as it seams like we would have already reached an error if it got to the point where there is no uploader name. Inside the else we also don't remove the binding.detailSubChannelTextView view, so I was not sure if it was accurate to remove binding.detailSubChannelThumbnailView or not.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[litetex]

LGTM :)