Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Respect cutouts when playing in MultiWindow" #7924

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

litetex
Copy link
Member

@litetex litetex commented Feb 21, 2022

This reverts commit c92a907.

What is it?

  • Bugfix (user facing)

Description of the changes in your PR

#7451 causes multiple problems:

As nearly no one benefited from #7451 (there was not even an issue), I am strongly for reverting the behavior.

Before/After Screenshots/Screen Record

See the issues

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@litetex litetex added the bug Issue is related to a bug label Feb 21, 2022
@sonarcloud
Copy link

sonarcloud bot commented Feb 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@TobiGr TobiGr merged commit c42f294 into TeamNewPipe:dev Feb 21, 2022
@litetex litetex deleted the revert-7451 branch February 21, 2022 20:51
@Stypox Stypox mentioned this pull request Feb 23, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notch not filled in full screen mode Player UI hidden during portrait mode playback
2 participants