Add an ExoPlayer settings page #8875
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| package org.schabi.newpipe.player.helper; | ||
|
|
||
| import android.content.Context; | ||
| import android.os.Handler; | ||
|
|
||
| import androidx.annotation.Nullable; | ||
|
|
||
| import com.google.android.exoplayer2.mediacodec.MediaCodecAdapter; | ||
| import com.google.android.exoplayer2.mediacodec.MediaCodecSelector; | ||
| import com.google.android.exoplayer2.video.MediaCodecVideoRenderer; | ||
| import com.google.android.exoplayer2.video.VideoRendererEventListener; | ||
|
|
||
| /** | ||
| * A {@link MediaCodecVideoRenderer} which always enable the output surface workaround that | ||
| * ExoPlayer enables on several devices which are known to implement | ||
| * {@link android.media.MediaCodec#setOutputSurface(android.view.Surface) | ||
| * MediaCodec.setOutputSurface(Surface)} incorrectly. | ||
| * | ||
| * <p> | ||
| * See {@link MediaCodecVideoRenderer#codecNeedsSetOutputSurfaceWorkaround(String)} for more | ||
| * details. | ||
| * </p> | ||
| * | ||
| * <p> | ||
| * This custom {@link MediaCodecVideoRenderer} may be useful in the case a device is affected by | ||
| * this issue but is not present in ExoPlayer's list. | ||
| * </p> | ||
| * | ||
| * <p> | ||
| * This class has only effect on devices with Android 6 and higher, as the {@code setOutputSurface} | ||
| * method is only implemented in these Android versions and the method used as a workaround is | ||
| * always applied on older Android versions (releasing and re-instantiating video codec instances). | ||
| * </p> | ||
| */ | ||
| public final class CustomMediaCodecVideoRenderer extends MediaCodecVideoRenderer { | ||
|
|
||
| @SuppressWarnings({"checkstyle:ParameterNumber", "squid:S107"}) | ||
| public CustomMediaCodecVideoRenderer(final Context context, | ||
| final MediaCodecAdapter.Factory codecAdapterFactory, | ||
| final MediaCodecSelector mediaCodecSelector, | ||
| final long allowedJoiningTimeMs, | ||
| final boolean enableDecoderFallback, | ||
| @Nullable final Handler eventHandler, | ||
| @Nullable final VideoRendererEventListener eventListener, | ||
| final int maxDroppedFramesToNotify) { | ||
| super(context, codecAdapterFactory, mediaCodecSelector, allowedJoiningTimeMs, | ||
| enableDecoderFallback, eventHandler, eventListener, maxDroppedFramesToNotify); | ||
| } | ||
|
|
||
| @Override | ||
| protected boolean codecNeedsSetOutputSurfaceWorkaround(final String name) { | ||
| return true; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| package org.schabi.newpipe.player.helper; | ||
|
|
||
| import android.content.Context; | ||
| import android.os.Handler; | ||
|
|
||
| import com.google.android.exoplayer2.DefaultRenderersFactory; | ||
| import com.google.android.exoplayer2.Renderer; | ||
| import com.google.android.exoplayer2.mediacodec.MediaCodecSelector; | ||
| import com.google.android.exoplayer2.video.VideoRendererEventListener; | ||
|
|
||
| import java.util.ArrayList; | ||
|
|
||
| /** | ||
| * A {@link DefaultRenderersFactory} which only uses {@link CustomMediaCodecVideoRenderer} as an | ||
| * implementation of video codec renders. | ||
| * | ||
| * <p> | ||
| * As no ExoPlayer extension is currently used, the reflection code used by ExoPlayer to try to | ||
| * load video extension libraries is not needed in our case and has been removed. This should be | ||
| * changed in the case an extension is shipped with the app, such as the AV1 one. | ||
| * </p> | ||
| */ | ||
| public final class CustomRenderersFactory extends DefaultRenderersFactory { | ||
|
|
||
| public CustomRenderersFactory(final Context context) { | ||
| super(context); | ||
| } | ||
|
|
||
| @SuppressWarnings("checkstyle:ParameterNumber") | ||
| @Override | ||
| protected void buildVideoRenderers(final Context context, | ||
| @ExtensionRendererMode final int extensionRendererMode, | ||
| final MediaCodecSelector mediaCodecSelector, | ||
| final boolean enableDecoderFallback, | ||
| final Handler eventHandler, | ||
| final VideoRendererEventListener eventListener, | ||
| final long allowedVideoJoiningTimeMs, | ||
| final ArrayList<Renderer> out) { | ||
| out.add(new CustomMediaCodecVideoRenderer(context, getCodecAdapterFactory(), | ||
| mediaCodecSelector, allowedVideoJoiningTimeMs, enableDecoderFallback, eventHandler, | ||
| eventListener, MAX_DROPPED_VIDEO_FRAME_COUNT_TO_NOTIFY)); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| package org.schabi.newpipe.settings; | ||
|
|
||
| import android.os.Bundle; | ||
|
|
||
| import androidx.annotation.Nullable; | ||
|
|
||
| public class ExoPlayerSettingsFragment extends BasePreferenceFragment { | ||
|
|
||
| @Override | ||
| public void onCreatePreferences(@Nullable final Bundle savedInstanceState, | ||
| @Nullable final String rootKey) { | ||
| addPreferencesFromResourceRegistry(); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I would make sure the preference does not get auto-created, and then use
!DeviceUtils.shouldSupportMediaTunneling()instead offalseas the value to use when the preference is not set.