Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support short custom YouTube channel URLs #409

Merged
merged 9 commits into from
Oct 25, 2020
Merged

Support short custom YouTube channel URLs #409

merged 9 commits into from
Oct 25, 2020

Conversation

Bartoshr
Copy link
Contributor

@Bartoshr Bartoshr commented Oct 9, 2020 •
edited
Loading

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

What is it ?

fixes TeamNewPipe/NewPipe#3608

@TobiGr TobiGr added the youtube service, https://www.youtube.com/ label Oct 9, 2020
TobiGr
TobiGr requested changes Oct 9, 2020
View reviewed changes
Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

.../schabi/newpipe/extractor/services/youtube/linkHandler/YoutubeChannelLinkHandlerFactory.java Outdated Show resolved Hide resolved
.../schabi/newpipe/extractor/services/youtube/linkHandler/YoutubeChannelLinkHandlerFactory.java Outdated
* @return true - if value conform to short channel url, false - not
*/
public boolean isCustomShortChannelUrl(String[] splitPath) {
return splitPath.length == 1 && !splitPath[0].matches("playlist|watch");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http://www.youtube.com/attribution_link?a=JdfC0C9V6ZI&u=%2Fwatch%3Fv%3DEhxJLojIE_o%26feature%3Dshare is a stream URL, but is accepted by your regex.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Thank you for review. Do you think that simply adding "attribution_link" to exlude those links with regex would be sufficent solution ? I couldn't come up with something better that that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmmh, probably a list of all pages not pointing to a channel should be added to that regex

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other YouTube URLs:

@Stypox what do you mean exactly?

@opusforlife2
Copy link
Collaborator

@Bartoshr Instead of writing "fix for", could you write "closes" or "fixes"? This will ensure the linked issue automatically closes when this PR is merged.

@Bartoshr
Copy link
Contributor Author

@opusforlife2 Sure, i will keep that in mind.

Bartoshr and others added 5 commits October 12, 2020 19:56
@Bartoshr @TobiGr
Fix typos
9d63211 
Co-authored-by: Tobias Groza <TobiGr@users.noreply.github.com>
@Bartoshr @TobiGr
Update extractor/src/main/java/org/schabi/newpipe/extractor/services/…
7abb4b3 
…youtube/linkHandler/YoutubeChannelLinkHandlerFactory.java


Fix typos

Co-authored-by: Tobias Groza <TobiGr@users.noreply.github.com>
@Bartoshr @TobiGr
Update youtube channel link handler tests
5ab1b05 
Co-authored-by: Tobias Groza <TobiGr@users.noreply.github.com>
Exlude links which are not channels
e3f996e
Exlude links which are not channels
d3f80d1
Stypox
Stypox requested changes Oct 22, 2020
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Remember to add final anywhere possible.
@wb9688 I'd merge this after the changes are implemented, even though probably the list of possible hardcoded non-channel urls may be bigger. We can always add more later

.../schabi/newpipe/extractor/services/youtube/linkHandler/YoutubeChannelLinkHandlerFactory.java Outdated Show resolved Hide resolved
.../schabi/newpipe/extractor/services/youtube/linkHandler/YoutubeChannelLinkHandlerFactory.java Outdated Show resolved Hide resolved
TobiGr
TobiGr reviewed Oct 23, 2020
View reviewed changes
Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just a small change.

.../schabi/newpipe/extractor/services/youtube/linkHandler/YoutubeChannelLinkHandlerFactory.java Outdated Show resolved Hide resolved
@TobiGr TobiGr requested a review from Stypox October 23, 2020 17:20
@TobiGr TobiGr changed the title Support short custom youtube channel urls Support short custom YouTube channel URLs Oct 23, 2020
Stypox
Stypox approved these changes Oct 25, 2020
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Stypox Stypox merged commit 8026304 into TeamNewPipe:dev Oct 25, 2020
This was referenced Nov 10, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opusforlife2 opusforlife2 opusforlife2 left review comments

@Stypox Stypox Stypox approved these changes

@TobiGr TobiGr TobiGr approved these changes

Assignees
No one assigned
Labels
youtube service, https://www.youtube.com/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

youtube.com/username channel links aren't supported
4 participants
@Bartoshr @opusforlife2 @TobiGr @Stypox