Support SoundCloud HLS-only tracks by using a workaround

[AudricV]

Support SoundCloud HLS-only streams by parsing M3U manifests, get the last segment URL (in order to get track length) and request a segment URL equals to track's duration so it's a single URL (0/track_length/).

• I carefully read the contribution guidelines and agree to them.
• I have tested the API against NewPipe.

Related issue: #273

Test APK: app.zip (from my fork with GitHub CI, app based on dev branch)

To do: add tests, if there is no risk of takedown of this repo by RIAA or by other music rights management companies by the use of SoundCloud HLS-only tracks.

[Stypox]

The issue is apparently that the streams that you open always end up in a continue; case, and therefore at the end of getAudioStreams() audioStreams.isEmpty() is true.

[Stypox]

@TiA4f8R ok, I'm gonna try to debug this myself. Since I'm pretty busy in the next few days, if I forget about this feel free to ping me ;-)

[AudricV]

@Stypox I've seen what's wrong: it's my regex.

[AudricV]

@Stypox Code ready for review and HLS-only tracks are now streamable.

[XiangRongLin]

Overall the code is very hard to read and there are no unit tests for the added functionality.

There is a for loop which spans across nearly 100 lines (I think, cant really see where it ends). Add to that if-else if-else, more loops inside and sudden jumps with `continue´ where you have to know in which loop you are.

---

Try to extract out some methods. You already have comments describing that the section is for a specific type of endpoint. Make a method out of that.

I just looked at it until the my last comment. I did not look at the rest.

[XiangRongLin]

Something along the lines of having getAudioStream be an integration method and the extracted method containing the actual operation. The integration method can then be "read" like normal text and not programming code, to get to know what is done.

see https://clean-code-developer.com/grades/grade-1-red/#Integration_Operation_Segregation_Principle_IOSP

[B0pol]

Also extract the regex pattern to a constant and give it a proper name.

[XiangRongLin]

@TiA4f8R I'm still not seeing any unit tests, please add those.
Before i review the code for quality, i would like to know beforehand that it actually works by seeing unit tests.

[AudricV]

@XiangRongLin What do you think now?

[XiangRongLin]

@TiA4f8R Grab yourself the SonarLint plugin. It gives you an objective review of bad practices, code smell and much more. In this case cyclomatic complexity is the important one.

From a quick scan it seems only a minor problem is present in the part that you touched. Decide for yourself if it is worth fixing, since it's probably you that has to touch that code again and try to comprehend it. I would just skip it for now. Come back when you have ideas on how to tackle it, because i don't

https://plugins.jetbrains.com/plugin/7973-sonarlint

[AudricV]

@XiangRongLin Thank you.

The only thing that I want to implement but I don't know how to is the support of SoundCloud downloadable files (original files uploaded by the artist, when the artist allows downloads of his/her/its track).

I know how to get the URL and add an audioStream but there are two missing informations: the bitrate and the format. Here is my initial work:

I was thinking of returning -1 when bitrate is unknown and MediaFormat.ORIGINAL_FORMAT when format is unknown.

        // If the track can be downloadable on SoundCloud's website, add the original file to the audioStreams only if there is standard streams available in order to prevent a high data consumption
        if (!audioStreams.isEmpty()) {
            if (track.getBoolean("downloadable")) {
                try {
                    final String dl_res = dl.get("https://api-v2.soundcloud.com/tracks/" + track.getInt("id") +
                            "/download?client_id=" + SoundcloudParsingHelper.clientId()).responseBody();
                    final JsonObject downloadUrlObject = JsonParser.object().from(dl_res);
                    audioStreams.add(new AudioStream(downloadUrlObject.getString("redirectUri"), MediaFormat.ORIGINAL_FORMAT, -1));
                } catch (final NullPointerException | IOException | JsonParserException ignored) {
                }
            }
        }

What do you think about what I should do?

[AudricV]

I installed the plugin and here are the issues:

However, I don't understand how to fix it (sorry for my current programming knowledge). Can you help me please? Thank you in advance!

[XiangRongLin]

However, I don't understand how to fix it (sorry for my current programming knowledge). Can you help me please? Thank you in advance!

Most of the issues are not from you, so don't worry about them.

The issues should all have an explanation with examples breaking and examples adhering to the rules. As for how to fix them: I don't know.

As I already mentioned it in my previous post. Come back to them when you know more.

Stale review

[TobiGr]

Structure looks good. Thank you for having a look!

[AudricV]

Thank you for your suggestions @TobiGr. I will apply it soon.