[YouTube] Fix trending getName() #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
TobiGr
approved these changes
Mar 24, 2021
AudricV
added
bug
3 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the title was nested inside a
JsonObject, so callinggetTextFromObject()was needed; now it is just provided as a rawString. Just to be sure I added agetTextAtKey()function that checks the data type at a specific key, and if it isStringthengetString(key)is returned, otherwisegetTextFromObject(getObject(key))is returned.Fixes TeamNewPipe/NewPipe#5893
Fixes TeamNewPipe/NewPipe#5895
Fixes #581