Japanese IME Issue

[vvakame]

material-ui-chip-input is awesome library! thanks a lot.

so, I have some issue related Japanese IME.
Enter key has 2 means for Japanese IME user.

1. input enter (same as ASCII user)
2. confirm character convert

material-ui-chip-input can't handle pattern 2 correctly.
I think problem is maybe here

material-ui-chip-input/src/ChipInput.js

Lines 721 to 722 in 6405afa

	newChipKeyCodes: [13],
	newChipKeys: ['Enter'],

pattern 1 and 2 have same key 'Enter'. but keyCode is different. 13 and 229.
so, I tried newChipKeys={[]} in my app. It's works fine (maybe...)

can we remove 'Enter' from newChipKeys?

related
#160
moroshko/react-autosuggest#388

[leMaik]

so, I tried newChipKeys={[]} in my app. It's works fine (maybe...)

That would be the fix, but it's already possible to do that on the user side and a default of 'Enter' is a good thing for ASCII users. That said, ASCII users also have keyCode 13, so I'm not really sure what to do here.

Instead of changing the default value, maybe we should add a Japanese IME example. What do you think?

[vvakame]

make sense.
Japanese user will search this github repository's issue with Japanese (or CJK), they will be find this issue. It's maybe useful already.
so, It might be even nicer if it was written in READMD.md. 😸

[leMaik]

@vvakame Would you like to add an example to the storybook? :-)

[vvakame]

okey, I'll try it & send PR 😸

I slept overnight and reconsidered.
I'm a Japanese IME user. but Library user (= app developer) is not CJK IME user almost.
so, I think provides better default settings that is good for all CJK IME user who uses this library via apps.

in react-autosuggest, they are not using event.key in there handler.
https://github.com/moroshko/react-autosuggest/blob/master/src/Autosuggest.js#L657

I think change default settings to newChipKeys:[] is maybe works fine in ASCII user.
but I don't know is it okay on other language's input method... 😿

[leMaik]

I think change default settings to newChipKeys:[] is maybe works fine in ASCII user.
but I don't know is it okay on other language's input method... crying_cat_face

@vvakame Unfortunately (e.g. #309), that wouldn't solve the issue either.

[tk-r1d3r]

okey, I'll try it & send PR 😸

I slept overnight and reconsidered.
I'm a Japanese IME user. but Library user (= app developer) is not CJK IME user almost.
so, I think provides better default settings that is good for all CJK IME user who uses this library via apps.

in react-autosuggest, they are not using event.key in there handler.
https://github.com/moroshko/react-autosuggest/blob/master/src/Autosuggest.js#L657

I think change default settings to newChipKeys:[] is maybe works fine in ASCII user.
but I don't know is it okay on other language's input method... 😿

thats really helped me. thanks