Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forked this project, republished and willing to help with features #111

Open
SnekCode opened this issue Aug 1, 2021 · 7 comments
Open

Comments

@SnekCode
Copy link

SnekCode commented Aug 1, 2021

Hello,

I wanted to use this library for React 17+ and Next js but wasn't sure how to submit Pull requests in order to update features.
I forked this project and converted it to 100% typescript with jest tests. I was able to publish the new package to npm!

Heres My fork If the team likes these changes lets discuss a PR.

Working to add a move left boolean prop which addresses Issue #84(Move SearchIcon to the left)

@leMaik
Copy link
Member

leMaik commented Aug 1, 2021

Just open a PR if you want :)

@SnekCode
Copy link
Author

SnekCode commented Aug 4, 2021

@leMaik I changed a lot but it should deploy the same, I'll open a PR and we can have discussions :)

Updated somethings today to address #84 and #86 and #106. See my GH page for examples.

@binarykitchen
Copy link

What's happening with the fork and PR??

@SnekCode
Copy link
Author

SnekCode commented Nov 25, 2021

No changes to Fork or PR since my initial opening of this thread. No one has reached out to discuss the PR. Fork works with React 17+. @binarykitchen did you have any particular questions?

@recursiveElk
Copy link

@SnekCode I tried your package and it appears to have an issue displaying the Clear button for me.

@SnekCode
Copy link
Author

SnekCode commented Dec 6, 2021

@recursiveElk if you can open a ticket on my repo and give an example of how you are using it I'd be glad to solve the issue :)

@leMaik
Copy link
Member

leMaik commented Oct 17, 2022

@SnekCode I pretty much lost track with this project (we don't use it anywhere currently). Your PR looks great, I just merged another PR that brings React >=17 support.

Maybe we should just merge your PR v2.0.0 and be done with it? 🤔 Not sure what's the best way forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants