Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not consider Java 8 (1.8) to be Java 1 #35

Open
TechnicJelle opened this issue Dec 18, 2024 · 2 comments
Open

Do not consider Java 8 (1.8) to be Java 1 #35

TechnicJelle opened this issue Dec 18, 2024 · 2 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@TechnicJelle
Copy link
Owner

Here I extract the first number from the message, but Java 8 is also sometimes referred to as Java 1.8
Then, printing "Java 1 is too old" is a bit extreme...

@TechnicJelle TechnicJelle added bug Something isn't working enhancement New feature or request labels Dec 18, 2024
@TechnicJelle
Copy link
Owner Author

Maybe I'll extract the first two parts and parse them as doubles..?

@TechnicJelle
Copy link
Owner Author

TechnicJelle commented Dec 18, 2024

Or I could do a specific check for 1.\d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant