Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list of unused modversions on dashboard #318

Open
Loscillo opened this issue Feb 26, 2015 · 8 comments
Open

Add list of unused modversions on dashboard #318

Loscillo opened this issue Feb 26, 2015 · 8 comments

Comments

@Loscillo
Copy link

Hi,

I noticed that after creating several builds, one can quickly end up with versions of mods that no longer serve any modpack.

The idea is to display a list of mods to inform the user that their removal is safe and that it can also remove the hard drive.

I did a fork and a commit (42284bb811631e798cea36d84a19000f00beff9d and 5f695c30a360e9962322b2c459d8762b9ad8e962) that implements this functionality. However, I find that the code in the controller is not the cleanest that can exist, so if there is an easier way (as a query like the rest) that would be practical.

Good day.

@GenPage
Copy link
Contributor

GenPage commented Feb 28, 2015

Its a good idea, but we should get some more input on this. I dont want to clutter up the dashboard too much

@Loscillo
Copy link
Author

Indeed, the dashboard is not necessarily the best place to put this kind of data. Perhaps below the list of mods (/mod/list)?

@Arzte
Copy link

Arzte commented Feb 28, 2015

hmm, maybe a warning like "You have 5 unused versions of modx" when you visit a mod's page?

@Loscillo
Copy link
Author

Loscillo commented Mar 1, 2015

Interesting solution and probably easier to implement (I did not yet look at the code to implement this solution).

However, the user may not see the information, but this can be a good compromise.

@EmielSlootman
Copy link

But i see no scenario where i would use it

@Loscillo
Copy link
Author

Loscillo commented Mar 1, 2015

I had the need when I have prepared a new build of a modpack. I usually check the mods, and download their updates and finally I test the build. Sometimes a mod is again updated during this period and so I will update the build. Therefore, the previous update of the mods is no longer used.

Also, after a while, the creator of a modpack may well remove a build. We can then have versions of mods that will not be used by any other build.

@ghost
Copy link

ghost commented Mar 19, 2015

or possibly Mod>Notifications

btw, 1+ on this :P

@vedalken254
Copy link

+1 on this. However, I would say do a small block notification that the user can click on and be redirected to a page solely devoted to the mods not being used anywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants