Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support vertical map layout #23

Open
jhelwig opened this issue Jul 8, 2018 · 1 comment
Open

Support vertical map layout #23

jhelwig opened this issue Jul 8, 2018 · 1 comment
Labels
enhancement New feature or request future Something that would be nice to have, but isn't currently planned to be worked on help wanted Extra attention is needed

Comments

@jhelwig
Copy link
Member

jhelwig commented Jul 8, 2018

Currently, only the horizontal map layout is supported. There should be a customization option for switching to the vertical map orientation.

@jhelwig jhelwig added enhancement New feature or request help wanted Extra attention is needed future Something that would be nice to have, but isn't currently planned to be worked on labels Jul 8, 2018
@jhelwig
Copy link
Member Author

jhelwig commented Jul 8, 2018

List of things that will need to be updated (not a complete list):

  • The location data in /ui/src/dungeonLocations.js and /ui/src/poiLocations.js will need to be updated to differentiate between the horizontal & vertical layouts, and the vertical layout data will need to be added.
  • /ui/src/components/map/Location.vue should probably be updated to take a location object, instead of just a few properties from it (similarly to how /ui/src/components/map/Dungeon.vue already does).
  • Both /ui/src/components/map/Location.vue and /ui/src/components/map/Dungeon.vue will need to be made aware of the map orientation setting so they can pick the appropriate set of coordinates for locations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request future Something that would be nice to have, but isn't currently planned to be worked on help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant