Convert to jest #12
Open
Convert to jest #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndp
commented
Jun 21, 2021
| @@ -46,4 +46,4 @@ Welcome to your daily practice challenge! You only need to do one challenge per | |||
|
|
|||
| ### Technology | |||
|
|
|||
| This project uses Jasmine to test JavaScript files. | |||
There was a problem hiding this comment.
I made just the necessary text changes to documentation.
ndp
commented
Jun 21, 2021
| @@ -0,0 +1,192 @@ | |||
| /* | |||
There was a problem hiding this comment.
This is the standard jest config file, with a slight change to line 150, where the file matching is done.
ndp
commented
Jun 21, 2021
| "version": "1.0.0", | ||
| "description": "", | ||
| "main": "index.js", | ||
| "dependencies": { | ||
| "jasmine": "^3.6.3" | ||
| "jest": "*" |
There was a problem hiding this comment.
The version number here is not necessary and adds an additional step during upgrades.
|
this is awesome, thank you!! do the test themselves need any conversion? |
|
Just tested it, I'm gonna say they need conversion. Would you like to do this part yourself? If not, I can make a jest branch, and another card that addresses the remaining issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Techtonica/curriculum#1572